Repository navigation
Point fragments on a paged field to nodes - #114
Merged
Merged
Conversation
A fragment on the node type selected directly on a connection
(animals { ... on Spider { ... } }) got "A fragment on Spider cannot
apply to AnimalsConnection", which does not say what to do. It now gets
the same paged-field fix as a plain field.
Eval: ask for the speed of each animal (only answerable through the
fragments, unlike 'fastest', which sorting by legs answered by luck),
and ask for the animal's name rather than 'which animal'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the second eval run: the agent wrote
animals { ... on Spider { name } }and got "A fragment on Spider cannot apply to AnimalsConnection", which does not say what to do.QueryValidator.FragmentType: a fragment on a connection's node type (or one of its possible types) now gets the paged-field fix: "This field is paged; put... on Spiderinsidenodes { ... on Spider { ... } }".speedcomes from a second interface, so it can only be read through fragments, and it can't be sorted on; "Which animal is the fastest?" was answered twice by sorting on legs, which happens to give the same animal.Eval against Foundry (gpt-5.4-mini) with the fix: the agent fixed the fragment error in one step in every run where it hit it. Tests: 297 passed, 0 warnings.