Repository navigation
Remove the unused StarWars.Client project - #120
Merged
Merged
Conversation
The doc site stopped using it when the samples were removed. The only remaining reference was the Console playground, which registered the client but had the code that used it commented out. Since the Console project is in the CI solution filter, CI was still building it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
docs/StarWars.Client, the generated Star Wars client that only the doc site's samples used. The samples were removed in #116.Linq2GraphQL.sln.test/Linq2GraphQL.Consolestill referenced it. It registered the client in dependency injection, but the code that queried it was commented out. This PR removes the reference, the registration and the commented-out code, and refreshes the Console lock file. The Console project is in the CI solution filter, so CI was still building the Star Wars client on every run.CLAUDE.mdthat listeddocs/StarWars.Clientamong the folders outside CI.dotnet restore Linq2GraphQL.CI.slnf --locked-modeanddotnet build Linq2GraphQL.CI.slnfpass locally.