Repository navigation
interp: G92.1, G92.2 and G92.3 report their errors - #4763
Merged
Merged
Conversation
convert_g() stored the result of convert_g92_is_applied() in status and went on without checking it, since G92.2 and G92.3 got their own modal group in 26aeab9 (2016). So every refusal of G92.1, G92.2 and G92.3 was dropped: the code stopped before changing anything and the line carried on as if it had run. Under cutter radius compensation a G92.1 did nothing instead of raising "Cannot change axis offsets with cutter radius comp", and under a tilted work plane none of the three raised "Cannot change G92 offsets while a tilted work plane (G68.2) is active" the way G92 does. The result is checked now, like every other step there. tests/interp/g68-words runs G92.1, G92.2 and G92.3 in a tilted work plane and G92.1 under G41.1; all four were "ok" before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert_g()stores the result ofconvert_g92_is_applied()instatusand never checks it (since 26aeab9, 2016). So an error fromG92.1,G92.2orG92.3is dropped: the code stops before changing anything and the line carries on as if it had run, with nothing said.On master:
G41.1 D2thenG92.1: nothing happens, whereG92 X1in the same state raises "Cannot change axis offsets with cutter radius comp".G68.2 X1 J30thenG92.1,G92.2orG92.3: nothing happens, whereG92 X1raises "Cannot change G92 offsets while a tilted work plane (G68.2) is active".The fix is one
CHP(status), like the other steps inconvert_g().tests/interp/g68-wordsgains the four cases; all four read "ok" on master and give the error with the fix. Full test suite passes.