Skip to content

tests: mdi-while-queuebuster-waitflag starts once and checks the MDI order - #4818

Open
grandixximo wants to merge 1 commit into
LinuxCNC:masterfrom
grandixximo:mdi-queuebuster-single
Open

grandixximo wants to merge 1 commit into
LinuxCNC:masterfrom
grandixximo:mdi-queuebuster-single

Conversation

@grandixximo

Copy link
Copy Markdown
Contributor

Cuts tests/mdi-while-queuebuster-waitflag from 20 starts (about 27 s) to one (about 1.3 s), as discussed in #4782.

The 20 starts looked for a segfault from an MDI issued while a yielding remap is suspended. The guard from 7e640f7 still prevents that, and the test cannot reach that task cycle any more: the MDIs after M400 arrive once the remap has finished, or while task holds its PLAN_SYNCH, so they are queued every time.

The single start now checks that the MDIs queued behind the remap run after it, in order. It passes 18 of 18 runs, 6 at a time beside 6 busy loops.

…order

The test started LinuxCNC 20 times and looked for a segfault, about 27 s.
The MDIs it sends after M400 arrive after the yielding remap has finished
or while task holds its PLAN_SYNCH, so they are queued every time, and the
starts could not hit the one task cycle the 7e640f7 guard closes.

Start once and check that the MDIs queued behind the remap run after it,
in order. The test now takes about 1.3 s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant