Repository navigation
tests: mdi-while-queuebuster-waitflag starts once and checks the MDI order - #4818
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
…order The test started LinuxCNC 20 times and looked for a segfault, about 27 s. The MDIs it sends after M400 arrive after the yielding remap has finished or while task holds its PLAN_SYNCH, so they are queued every time, and the starts could not hit the one task cycle the 7e640f7 guard closes. Start once and check that the MDIs queued behind the remap run after it, in order. The test now takes about 1.3 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts
tests/mdi-while-queuebuster-waitflagfrom 20 starts (about 27 s) to one (about 1.3 s), as discussed in #4782.The 20 starts looked for a segfault from an MDI issued while a yielding remap is suspended. The guard from 7e640f7 still prevents that, and the test cannot reach that task cycle any more: the MDIs after M400 arrive once the remap has finished, or while task holds its PLAN_SYNCH, so they are queued every time.
The single start now checks that the MDIs queued behind the remap run after it, in order. It passes 18 of 18 runs, 6 at a time beside 6 busy loops.