Repository navigation
fix(windows): prevent VHF report buffer overruns - #200
Open
ReenigneArcher wants to merge 1 commit into
Open
ReenigneArcher wants to merge 1 commit into
ReenigneArcher wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
========================================
Coverage 73.71% 73.71%
========================================
Files 43 44 +1
Lines 10670 10680 +10
Branches 3677 3681 +4
========================================
+ Hits 7865 7873 +8
+ Misses 2445 2183 -262
- Partials 360 624 +264
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On affected Windows 10 systems, a DualSense pairing GetFeature callback advertises 128 bytes for a 64-byte VHF buffer. Clearing the advertised length overwrites the allocation and crashes WUDFHost; the PageHeap dump in #199 catches that write directly.
Use a shared response copier in GetFeature and GetInputReport that writes only the actual report bytes. Preserve undersized-request rejection and the optional zero ID for unnumbered input reports.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
test_libvirtualhidandgamepad_adapter; 47 focused protocol, backend, lifecycle, adapter, and native HID/SDL tests passed.cmake --build cmake-build-issue199-msvc-driver --config Release --target libvirtualhid_umdf -j 4passed.clang-format --dry-run --Werroron the three changed files andgit diff --checkpassed.Type of Change
Checklist
AI Usage
See our AI usage policy.
Generated with Codex (model: gpt-6.1-sol; thinking level: xhigh).