Repository navigation
chore(muix): name gemini-4-argon as author of 20 adopted files - #12298
Merged
Merged
Conversation
The 20 MUI X 9 implementations adopted from gemini/12267-muix-9-batch1 (PRs #12276 to #12295) were written by Gemini 4 Argon in the owner's interactive Antigravity session (issue #12267, draft #12275). Their metadata said generated_by: adopted:gemini/12267-muix-9-batch1, the form adopt mode wrote before source_model existed. This changes generated_by to gemini-4-argon and adds adopted_from with the ref and its commit 8cfea56, the head the pipeline adopted from. Nothing else changes. Owner-authorized metadata correction (2026-10-23); metadata is normally pipeline-written. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are limited to the intended provenance metadata correction, with no unresolved review issues.
No open issues 🎉
What changed in this PR
This pull request corrects provenance metadata for 20 MUI X implementations migrated by Gemini 4 Argon, preserving their original adoption source.
Changes:
- Replaces
generated_by: adopted:gemini/12267-muix-9-batch1withgenerated_by: gemini-4-argon. - Adds
adopted_from: gemini/12267-muix-9-batch1 (8cfea568c)to each affected file. - Leaves implementation data and the unrelated
gauge-activity-ringsmetadata unchanged.
| File | Description |
|---|---|
plots/ternary-density/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/sequence-logo-basic/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/scatter-color-mapped/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/scatter-annotated/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/recurrence-basic/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/phase-diagram/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/map-marker-clustered/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/line-stepwise/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/line-loss-training/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/horizon-basic/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/hexbin-basic/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/genome-track-multi/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/gauge-basic/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/datamatrix-basic/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/confusion-matrix/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/calibration-curve/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/calibration-beer-lambert/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/area-basic/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/alluvial-basic/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
plots/acf-pacf/metadata/javascript/muix.yaml |
Records Gemini provenance and the adoption source. |
Review effort: Lite
4 of 5 tasks
MarkusNeusinger
added a commit
that referenced
this pull request
Oct 23, 2026
## Summary
- New optional input `source_model` on `impl-generate.yml` and
`bulk-generate.yml` names the model that wrote an adopted
implementation, for example `gemini-4-argon`. It must match
`^[A-Za-z0-9][A-Za-z0-9._-]{0,39}$`; anything else stops the run.
Without `source_ref` it is dropped with a warning.
- Adopt-mode metadata now writes `generated_by: <source_model>` (still
`adopted:<ref>` without one) and always adds `adopted_from: <ref>
(<sha>)` right after `generated_by`, with the full SHA the adopt step
resolved. Every other key is unchanged. The PR body line reads
`**Generation:** adopted from <ref> (<sha>) by <source_model>; the model
below runs repair`; the issue preview comment, the adopt commit, the
step summaries and the `::notice::` lines name the model too.
- bulk-generate forwards `source_model` on both dispatch branches
exactly like `source_ref`. impl-generate's `dispatch_retry` and its
three manual rerun hints (infrastructure pause, retry cap, adoption
failed) keep it as well.
- Hardening from review: neither workflow echoes a rejected `source_ref`
or `source_model` any more (a newline in a dispatch value would start a
workflow command), and bulk-generate's plan preview checks both with
impl-generate's patterns before it prints anything, so a bad value stops
the bulk run before its first dispatch.
### Readers
- `automation/scripts/sync_to_postgres.py` copies a fixed key list, so
`adopted_from` is ignored and `gemini-4-argon` syncs into the existing
`generated_by` column (`String(100)`). No schema change.
- impl-review's metadata update and the regen write-back load the whole
mapping and keep unknown keys. `review_retest.py` mirrors the key set of
a fresh generation; `adopted_from` is inserted after the dict literal,
so that mirror and its test stay as they are.
- No API model or frontend type parses metadata files; the site shows
`generated_by` as a plain string (debug page) and has no model
statistics that filter on it. Nothing in `api/` or `app/` changes.
### Known gap
- The watchdog's generation rescues forward neither `source_ref` (as
before) nor `source_model`: a pair the watchdog re-dispatches is
generated by Claude. Left as it is on purpose.
### Decisions
- `adopted_from` carries the full 40-character SHA, the value the adopt
step resolves and the PR body already shows. The 20 MUI X files
backfilled in #12298 use the 9-character form `8cfea568c`.
- A malformed `source_model` fails the run even without `source_ref`, so
a typo never reaches a log line unchecked.
- The constant error for a rejected `source_ref` is new too: it had the
same echo two lines above the new check.
- `-f source_model=` is always sent, empty or not, like `-f
source_ref=`. Gemini Flash pointed out that GitHub answers 422 when a
target workflow lacks the input; that only happens for a dispatch from
this branch to a `main` without it, before merge.
### Reviews
- Gemini 3.8 Flash (first review): sound with changes. Adopted: validate
early in bulk-generate. Skipped: conditional `-f source_model` (see
Decisions).
- Copilot round 1: two high findings (raw value echoed into `::error::`
in impl-generate; raw value printed by bulk-generate before any check)
and one low doc finding. All fixed in 1bd31a8, threads resolved.
- Copilot round 2 (requested because round 1 had high findings): no open
issues. Two low doc notes about the metadata examples were fixed in
7a2ae73. Its headline about an unescaped malformed-model test input
does not match the code: every malformed-value test passes the value
through the environment. No further round.
## Plan
N/A
## Test plan
- [x] `tests/unit/workflows/test_impl_generate_adopt.py`: input
declarations on both workflows; only "Extract inputs" reads the raw
input, every consumer reads `steps.inputs.outputs.source_model`;
validation (valid names exported, malformed values including newline
injections fail without being echoed, with and without `source_ref`; a
model without `source_ref` warns and is dropped); the real adopt step
names the model in its commit, notice and summary; the metadata writer
emits `generated_by` and `adopted_from` in that order with all other
keys equal to a fresh generation's; the failure handler's retry and its
adoption-failed rerun command carry `source_model`; bulk-generate's
dispatch loop, plan preview and its input checks; the generate job
depends on the preview; both workflows use the same patterns.
- [x] `tests/unit/workflows/test_model_routing.py`: the PR body with
`source_model` round-trips through impl-review's and impl-repair's
rescues (repair model opus survives).
- [x] `tests/unit/automation/scripts/test_sync_to_postgres.py`: a muix
metadata file with `generated_by: gemini-4-argon` and `adopted_from`
scans cleanly; `adopted_from` is left out of the row.
- [x] `uv run ruff check .`, `ruff format --check .`, `mypy api core`,
`uv run pytest tests/unit -n auto` (13292 passed, 3 skipped before the
review fixes; workflow and automation tests 2823 passed after them),
`tools.changelog check --base origin/main`.
- [ ] Workflow YAML has no live verification loop. I reasoned through:
`set -u` in bulk-generate's dispatch step (the env var is always defined
there, possibly empty); `${SOURCE_MODEL:+…}` expansions under `bash -e`;
the inline Python in the metadata step receives only validated values
(no quotes possible); the generate job's custom `if` keeps the implicit
`success()` on `needs: preview`; a run dispatched by bulk-generate
always targets the default branch, so both workflows need to be on main
before `source_model` is used. No branch smoke was run, because one
would open a real adopt PR.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
MarkusNeusinger
added a commit
that referenced
this pull request
Nov 1, 2026
## Summary - Cuts v3.6.0 "All fifteen": `tools.changelog release` folds the 95 fragments of the window into `## [3.6.0] — 2026-11-01 — All fifteen` (170 entries: Added 63, Changed 57, Removed 2, Fixed 42, Security 6), repoints the compare links and bumps `pyproject.toml`, `uv.lock` and `app/package.json` to 3.6.0. - The window is 253 squash-merged PRs since v3.5.0 (#12160 to #12506). The milestone: the agent chat ("Use with my data") serves all 15 libraries for admins, plus today's user-test fixes #12502 to #12506. #12507 and the open sample-data, combo-request, date-convert and data-grid work are not on main and not in this release. - Hand-written aggregate lines: the `**Dependencies:**` bullet (14 Dependabot PRs; four security updates close 60 advisories, four critical and 32 high) and the italic `*Catalog:*` line (no new implementations or specs; 138 regenerations, 127 of them the MUI X 9 migration, 11 daily-regen improvements; 3 stored re-scores; coverage unchanged at 315 of 325 specs). Routine decisions, documented here: - Ten fragment bullets had no PR reference (`/pull_request` step 7 never ran for #12404, #12408, #12409, #12235, #12458, #12461, #12462). Before the cut, their real numbers were appended (found with `git log --diff-filter=A` on each fragment), and the two Jules fragments (#12408, #12409) were wrapped to the file's line width without changing their wording. - Completeness: every non-bot commit in `v3.5.0..origin/main` has an entry except #12469, #12471 and #12472 (`skip-changelog`; a temporary DEBUG diagnosis and its revert, net zero) and #12298 (`plots/`-only metadata attribution, exempt). No fragment was added. - Catalog count: implementation-file changes in the window, classified by whether the file existed at `v3.5.0` (all did, so no new implementations), cross-checked against the merged pipeline PRs' labels on GitHub (127 `regen:forced`, 11 `regen:improved`, 3 `review-writeback`); the MUI X split comes from `library_version` and `generated_by` in `plots/*/metadata/javascript/muix.yaml`. Advisory counts are unique GHSA ids of the Dependabot alerts fixed after the v3.5.0 tag; the nanoid and `@vitest/mocker` alerts closed by #12235 and #12249 belong to those PRs' own entries and are not counted. ## Plan `agentic/commands/release.md`, steps 1 to 5. The tag and the GitHub release (steps 6 and 7) follow after the merge. ## Test plan - [x] `uv run python -m tools.changelog release 3.6.0 --title "All fifteen" --dry-run`, then the real run - [x] The diff touches only `CHANGELOG.md`, `pyproject.toml`, `uv.lock`, `app/package.json` and the 95 deleted fragments - [x] `uv lock --check` passes; the lock changes only the project's own version line - [x] `uv run pytest tests/unit/test_version_sync.py` passes (2 tests) - [x] `uv run python -m tools.changelog check --base origin/main` passes - [ ] CI green https://claude.ai/code/session_01H7HSkGyea1k2v293XiAMo8 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gemini/12267-muix-9-batch1(PRs feat(muix): implement alluvial-basic #12276 to feat(muix): implement scatter-annotated #12295). Their metadata recordedgenerated_by: adopted:gemini/12267-muix-9-batch1, the only form adopt mode had beforesource_model.plots/<spec>/metadata/javascript/muix.yaml,generated_bybecomesgemini-4-argonandadopted_from: gemini/12267-muix-9-batch1 (8cfea568c)follows it. Nothing else changes: 20 files, 40 insertions, 20 deletions.Specs: alluvial-basic, calibration-beer-lambert, datamatrix-basic, genome-track-multi, horizon-basic, map-marker-clustered, phase-diagram, recurrence-basic, sequence-logo-basic, ternary-density, area-basic, confusion-matrix, hexbin-basic, line-stepwise, scatter-color-mapped, acf-pacf, calibration-curve, gauge-basic, line-loss-training, scatter-annotated.
Merge after #12297, which adds
source_modelto adopt mode and documents theadopted_fromkey. Plots-only, so no changelog fragment.Not touched:
gauge-activity-rings, whose metadata saysgenerated_by: adopted:mainfrom the adopt-mode smoke run of #12274. That file came frommain, not from Gemini.Plan
N/A
Test plan
generated_by: adopted:gemini/12267-muix-9-batch1exactly once, and no other metadata file did.8cfea568cresolves to8cfea568c8ff9311e21de7c0133a2e5ee506f089, the current head ofgemini/12267-muix-9-batch1and the SHA on the**Generation:**line of feat(muix): implement alluvial-basic #12276.git diffgrouped by line: 20 removals and 2 × 20 additions, no other lines).generated_by: gemini-4-argonandadopted_fromdirectly after it.sync_to_postgresreads a fixed key list, soadopted_fromis ignored and the next sync writesgemini-4-argoninto the existinggenerated_bycolumn (covered by a test in feat: record the adopting model with source_model in adopt mode #12297).🤖 Generated with Claude Code
https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza