Skip to content

fix(cleanup): Skip GIL scope when Python is finalized - #372

Merged
usiems merged 1 commit into
MeVisLab:mainfrom
Thibault-Pelletier:fix-threaded-cleanup-crash
Oct 26, 2026
Merged

usiems merged 1 commit into
MeVisLab:mainfrom
Thibault-Pelletier:fix-threaded-cleanup-crash

Conversation

@Thibault-Pelletier

Copy link
Copy Markdown
Contributor

Avoid crash during cleanup with threading enabled if Python has been finalized before cleanup.

Avoid crash during cleanup with threading enabled if
Python has been finalized before cleanup.
@Thibault-Pelletier
Thibault-Pelletier force-pushed the fix-threaded-cleanup-crash branch from 0c29b8c to ea9b373 Compare October 25, 2026 09:32
Comment thread src/PythonQtThreadSupport.cpp
@usiems
usiems merged commit 08b6873 into MeVisLab:main Oct 26, 2026
17 checks passed
@Thibault-Pelletier

Copy link
Copy Markdown
Contributor Author

@usiems thanks for merging this fix!
Don't hesitate to ping me if you see any race condition issues with it in the future (I'll also report back if needed if usage in CTK / Slicer digs up any problems related to it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants