Skip to content

permissions follow-ups from #781: read-only approval checks still prompt; install-claude-hooks.sh runs unprompted #782

Closed

Description

@MendixMau

Two non-blocking findings from the independent reviews of #781 (fixes #780).

1. Read-only approval checks still prompt, so exec approval auto still prompts on every exec.
#781 leaves the scripts that record a person's decision out of the allow list. They are exec-approval.sh, interview-mode.sh, permission-profile.sh, the two permission installers and init-project.sh. That keeps --set from running unprompted. It also means their read-only calls prompt every time, for example:

  • exec-approval.sh <proj> before each exec (bin/lib/wiring-item3.sh:33, bin/lib/skill-routing.tsv:123);
  • interview-mode.sh <proj> --explain (skills/interview-protocol.md:25).

This is unchanged from master, where the wildcard rules never matched. Under auto it is still the complaint in the installer header (bin/install-claude-permissions.sh:12-15).

Fix: allow the read forms and keep the setters prompting. For example, allow Bash(<toolkit>/bin/exec-approval.sh *) together with an ask rule Bash(*exec-approval.sh*--set*); ask and deny beat allow. Do the same for interview-mode.sh and permission-profile.sh. Prove it against a real claude the same way #781 was proven: the read is allowed, --set prompts.

2. bin/install-claude-hooks.sh still runs unprompted.
It writes ~/.claude/settings.json without confirmation, and the hooks it installs fire in every repo on the machine; --ceiling blocks tool calls everywhere (:181-206). It grants no permission, because the hooks are toolkit code. But its own header calls running it a person's decision.

Fix: add it to the exclusion case in _script_rules, to EXPECTED_LOCAL and to the T12 grep.

Activity

  1. MendixMau commented on Nov 16, 2026

    @MendixMau
    OwnerAuthor

    Triage: FIX track. Bug, verified by the two #781 reviews.

    Root cause / Problem: after #781, these scripts get no allow rule:

    • exec-approval.sh and interview-mode.sh, so their read-only calls prompt as well as their --set;
    • install-claude-hooks.sh is the opposite case: it still gets one.

    Reference points:

    Value: M. Anyone using exec approval auto still gets a prompt on each exec's mode check, which is the original complaint in the installer header.

    Risk of fixing: L–M. It needs ask rules (Bash(*exec-approval.sh*--set*)), which beat allow. A wrong glob would let --set through, so it must be proven against a real claude as #781 was. No verdict or exit-code change, and no baseline words.

    Rigidity check: FIX. No process, architecture or performance change; only the permission rules.

    Process cost (#687): none per build row. It removes one prompt per exec under auto.

    Needs clarification: no.

    Learning value: none.

    Proposed fix:

    • Allow the read forms of exec-approval.sh, interview-mode.sh and permission-profile.sh, and add ask rules for their --set.
    • Add install-claude-hooks.sh to the exclusion case, to EXPECTED_LOCAL and to the T12 grep.

    Proof: a T12 case asserting that the read form is allowed, --set asks, and the hooks installer gets no rule, plus one real claude -p run: read allowed, --set denied.

    Effort: S. Recommendation: NEXT, after #781 merges, since it builds on it.

    Labels: kind/bug, lane/direct, size/xs.

    Reply go. Fix PRs still get an independent review and your merge.


    Generated by Claude Code

  2. MendixMau commented on Nov 16, 2026

    @MendixMau
    OwnerAuthor

    Maintainer decision (in chat, 2026-11-16): go. A fix PR follows.


    Generated by Claude Code

  3. MendixMau commented on Nov 16, 2026

    @MendixMau
    OwnerAuthor

    Fix PR opened: #785. Read-only calls are allowed, --set and --clear hit ask rules, and install-claude-hooks.sh is no longer allowed.

    I proved it on claude 2.1.325:

    Call Result
    the read runs
    --set refused
    control, without the ask rule --set runs

    The PR is in independent review.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions