Skip to content

fix: contract-check reports inline REST calls it did not check; doctor and test-scratch warn about an incomplete cached runtime (#674, #692) - #762

Merged
MendixMau merged 4 commits into
masterfrom
claude/loving-gates-hauc1n-bugs4b
Nov 15, 2026
Merged

MendixMau merged 4 commits into
masterfrom
claude/loving-gates-hauc1n-bugs4b

Conversation

@MendixMau

Copy link
Copy Markdown
Owner

Direct lane

What changed and why (one paragraph): Two instruments stop being silent about what they did not see; both follow the option their issue's triage chose. (A) contract-check prints one inline: line per app under check and --impact: how many inline call rest service activities it did not check (with the microflow names), 0 when the catalog is populated and has none, or "not measured" when it could not tell — never a silent 0/0. It is a separate mxcli call, so the 13 existing captured query sets stay valid and the denominator: line is byte-identical (closes #674). (B) doctor.sh and test-scratch.sh warn when the cached Mendix runtime is incomplete, naming what is missing, and on macOS mention a matching Studio Pro runtime if one exists; warning only, the run still happens and the exit code is unchanged (closes #692).

Row Answer
Process none: two informational lines; nothing new blocks
Dependencies contract-check.py / contract-check.sh; project-bin/_common.sh (four new functions), doctor.sh, test-scratch.sh
Context cost none: no routed or always-loaded file touched (baseline 66,196 on base and head)
Behaviour n/a: scripts only
Runtime (A) about 1.5 s per app per contract-check run (a catalog refresh plus two SELECTs). (B) five complete-runtime checks took 0.011 s in total. Time cost: per contract-check run · ~1.5 s per app on the build container · can force rework: n · offset: replaces a false "no consumers" with a counted gap

Measured, base vs head: (A) over every existing capture (4 check states, 2 impact runs) the only difference is the added inline: line per app ("not measured" for old captures); exit codes and every other line identical. (B) complete layout: old and new both accept it with no output; incomplete layout: old accepts, new warns with missing: bundles/org.osgi*.jar.

Field evidence — (A) golden input captured with mxcli v0.28.0 from copies of toolkit-built demo apps: one app with one inline REST call (in the public Feedback module), the same with that microflow dropped (zero rows), and an unrefreshed catalog (empty table). (B) the layout is a find listing of a real cached runtime (11.13.0), home paths removed; the incomplete case is that listing minus one jar. macOS and Windows paths NOT RUN. The repair command named in the warning could not be verified to fetch the runtime, and the message says so.

  • No client data anywhere in the diff
  • Size: 17 files, 1,083 lines, of which the captured runtime listing and the mxcli captures are the bulk
  • Test tier: scoped fixtures — test-contract-check.sh 68/68 (62/68 against master's engine), test-runtime-complete.sh 24/24, test-test-scratch.sh 131/131, doctor fixtures
  • Golden input captured, both layouts for contract-check (single tree and .mpr under app/)
  • CHANGELOG.md lines appended, credited

Generated by Claude Code

…bsence (#674)

A separate mxcli call counts RestCallAction rows in catalog.activities and prints an
inline: line under check and --impact; not measured when the table is empty or the call fails.
Denominator line, verdicts and exit codes unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
…d the matching Studio Pro runtime (#692)

mxcli accepts a runtime on its launcher jar alone; without bundles/org.osgi*.jar
local tests die at startup with no verdict. Warn, never block.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
…92' into claude/loving-gates-hauc1n-bugs4b

# Conflicts:
#	CHANGELOG.md
…rding and shape/exit tests

mxcli setup --help: 'mxruntime  Download the Mendix runtime for the project's Mendix version';
'setup mxruntime --help': 'The runtime is cached at ~/.mxcli/runtime/{version}/';
'setup mxbuild --help': 'The binary is cached at ~/.mxcli/mxbuild/{version}/'.
So the report names setup mxruntime for runtime/<v> and setup mxbuild for mxbuild/<v>; UNVERIFIED dropped.
contract-check header: three mxcli calls, catalog refreshed to full, no lock. Tests: 1/3 result sets and a
non-zero inline exit read 'not measured'.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
@MendixMau
MendixMau merged commit 6f4d052 into master Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants