Repository navigation
Conversation
… instead of 3 cold (#770) Per page: one LOOK at 1280 and one polish round; 390 on the first page only. Once at the end: one journey with the happy path, one negative step per business rule and per must-have, one cross-user refusal per role, ending in a logout; run it 2x (warm, then cold after one restart on the used DB), then the broken control without a restart, then one LOOK pass at 1280 + 390 over every page. "Done when" matches. Status stays EXPERIMENTAL and notes the new cadence is unmeasured. Skill 2144 -> 2178 words, on demand (baseline unchanged at 66196). The open-session-count assertion is a follow-up: the POC journey is its own script, not journey-runner.js, and a zero-after-logout check cannot be proven without a live runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX. "The script's last step logs out" is weaker than #729's actual fix, which logs out every session before closing it. A journey that now logs in as several users for the cross-user steps can still leak sessions and hit the 6-session cap. The broken-control run, which is meant to FAIL anyway, can then fail at sign-in and still look like a pass. Value: Implements #770's approved cadence (
Regression risk:
Correctness:
Context cost: 66196 → 66196 always-loaded words (measured). The on-demand file grows by +34 words. Time cost: per POC build, an estimated −10 to −15 min (from the issue, not measured). 2 app restarts and 1 journey run are removed. It can force rework at the end for phone-layout bugs. Exact fixes required:
Generated by Claude Code |
… at the changed step Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review fixes pushed in e94e2a2:
Needs a re-review before merge. Generated by Claude Code |
|
Review: MERGE. Re-review: both requested fixes landed in e94e2a2, and nothing else changed:
Value:
Regression risk: The fix commit touches only Correctness: No new issues. The session-count assertion is still deferred, as stated, and the Status line still marks the cadence unmeasured ( Context cost: 66196 → 66196 always-loaded words (measured). The on-demand file grows from 2144 to 2208 words. Time cost: per POC build, an estimated −10 to −15 min (from the issue, not measured). Nothing per build row. Generated by Claude Code |
Fixes #770
Direct lane
What changed and why (one paragraph): this changes the test cadence in
skills/poc-build.md, as approved in #770.The per-role cross-user refusal paragraph under the must-have list moved into step 8; it was not deleted. A few sentences elsewhere were condensed (the page pre-flight step names, the commit rule wording, the Nothing-path design questions) to keep the length flat. No rule was removed.
Session-leak assertion: a follow-up, not built here. The issue asks to assert an open-session count of 0 after each run.
project-tests/e2e/journey-runner.jsalready countsSystem.Sessionthrough the admin API, but only in its preflight (ADMIN_PROBE_SQL,classifyAdminProbe,JOURNEY_SESSION_CAP, around :1405–1550).journey-proof.mdrunner)". A runner flag would only reach it if the POC moved onto the runner, which is a wider change.So the skill instead requires the journey to end with a logout step and run 2 (cold, after a restart) to pass. A leak then shows up as run 2 failing at login. Suggested follow-up: an opt-in post-run probe that reuses
classifyAdminProbe, field-proven on a trial runtime.Impact
Build type: poc). Removed: 2 of 3 cold restarts, the third journey run, the second per-page polish round, and the per-page 390 LOOK after page 1. Added: a negative step per business rule and per must-have, a logout as the journey's last step, and a final LOOK pass at 1280 + 390 over every page. Nothing new blocks. No new stage artifacts.skills/poc-build.mdandCHANGELOG.mdonly. No shared scripts, noskill-routing.tsvchange. No fixture targetspoc-build.md(grep oftests/). No new artifact reads.poc-buildisondemandinskill-routing.tsv.bin/render-routing.sh --check: baseline 66196 → 66196 words (budget 80000) on both master and the branch. The skill file goes from 2144 to 2178 words (+34).Time cost: per project · not measured (est. −10 to −15 min, from the issue) · can force rework: y (phone-layout bugs on pages 2+ surface only in the final pass) · offset: removes 2 cold restarts, 1 journey run, per-page second polish round and 390 LOOK
Field evidence:
Proof (grep check, text-only change): a scratch script runs 11 assertions against the skill file. They check for:
Results:
skills/poc-build.md: 0 passed, 11 failedAlso ran:
bin/render-routing.sh --check: in sync, baseline 66196/80000;bin/check-scripts.sh: 137/137 shell, 30/30 Node parse;No selftest was added, since the runner was not changed.
CHANGELOG.mdline appended in this PR, crediting the [idea] Light mode: requirements or an idea to a running app in a 2-hour workshop, tested (27 min, $2.41, journey 15/15) #729/[idea] Thin harness for small builds (withdrawn) #730 light-mode experimentReview: pending independent review
Generated by Claude Code