Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Sections dated before 2026-09-19 predate the cycle and stay as they are. Named m
`docs/RELEASE-PROCESS.md` §8.

## Unreleased
- fix(intake,interview-protocol): **the intake preamble and `interview-protocol.md` now state the Stage P answer form for `Interview mode: auto`, `Assumed (auto-mode): <default> — rejected: <alt>`, colon right after the parenthesis (#766)**: the preamble listed only `Answered (CONFIRMED):` and `Unverified — how to verify:`, and the protocol said "recorded `ASSUMED` as above", pointing at the register shape the intake gate rejects, so an auto-mode kickoff learned the accepted form only from the FAIL message. Text only: the gate matcher and Q9 are unchanged, and existing intakes are not re-synced. Proof: `tests/wave2/test-stage-p.sh` T12 (fails on master's template) — field report from a greenfield auto-mode build, relayed by the maintainer
- process(poc-build): **POC test cadence cut to what finds bugs (#770)**: per page one LOOK at 1280 and one polish round (390 on the first page only); once at the end one journey with the happy path, one negative step per business rule and per must-have and one cross-user refusal per role, ending in a logout, run 2× (warm, then cold after one restart on the used DB) instead of 3 cold runs, then the broken control without a restart and one LOOK pass at 1280 + 390 over every page. "Done when" updated; status stays EXPERIMENTAL and says the new cadence is unmeasured. The open-session-count assertion after each run is a follow-up. — POC light-mode experiment (#729/#730), 2026-11
- learn(security): **MxAdmin no longer "ships with password `1`" in the rules (#662)**: `learned-mdl-preflight.md` (baseline), `brd-to-build-plan.md` Step 7 and the rendered `generated/rules-access.md` now say MxAdmin exists only where the runtime host created it (Studio Pro's own run, or the buildpack's `ADMIN_PASSWORD`); `mxcli run --local` never creates it (`MxAdmin user ... does not exist!`) and `mxcli docker build` seeds `admin` / `Admin123!` instead, so sign in as a demo user. The "never touch MxAdmin" rule stays — field run, 2026-11
- fix(build-tree): **`bin/build-tree.py` excludes `node_modules` at any depth, not only at the project root (#764)**: `skip()` ran only for top-level names, so a custom widget's nested `widgets/<W>/node_modules` (1.2 GB in the field) was copied into `.mxtk/build/model/` on every full build, and one exec stalled for 13+ minutes. A nested `node_modules` already in an existing copy is removed on the next sync; the other excluded names (`deployment`, `docs`, `.mxcli`, `.mxtk`, ...) stay top-level only, since a widget may hold its own. The one exception is the top-level `javascriptsource/` tree, whose `node_modules` hold JavaScript actions' npm dependencies that mxbuild bundles: those are still copied. `test-build-tree.sh` B4c covers both. — a Greenfield field run (2026-11-13)
Expand Down
7 changes: 5 additions & 2 deletions bin/lib/intake-template.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,16 @@ mxtk_intake_template() {
cat <<'MXTK_INTAKE_EOF'
# intake.md — Stage P Kickoff Interview

Replace each "_Not yet asked._" line below with a real answer, in one of two forms:
Replace each "_Not yet asked._" line below with a real answer, in one of three forms:

Answered (CONFIRMED): ... the question was asked and answered
Unverified — how to verify: ... the question WAS asked, the answer is not known yet,
and this line says how it will be established
Assumed (auto-mode): ... Interview mode: auto only — the recommended default;
the full record goes in PROJECT.md

Both forms pass gate-check's Stage P. "_Not yet asked._" passes nothing, deliberately: this
All three pass gate-check's Stage P (keep the colon right after the parenthesis).
"_Not yet asked._" passes nothing, deliberately: this
file is generated before the interview happens, and a scaffold must never be able to certify
an interview that never took place. Per conversion-runbook.md's interview protocol, every
question is asked in chat and the turn ends to wait for the answer; unknowns the user hands
Expand Down
3 changes: 2 additions & 1 deletion skills/interview-protocol.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ Failure this replaces: an unattended run produced every Stage 3–4 artifact, th
gates by design with nothing saying so (#624).

**No question stays "Not yet asked" under `auto`.** It gets its recommended default, recorded
`ASSUMED` as above. The intake's Marketplace question defaults to *"use the catalogued Marketplace
`ASSUMED` as above; in `intake.md` the answer line reads `Assumed (auto-mode): <default> — rejected: <alt>`,
colon right after the parenthesis, e.g. `Assumed (auto-mode): greenfield — rejected: requirements-driven` (`Assumed (auto) — greenfield`, no colon, FAILs Stage P). The intake's Marketplace question defaults to *"use the catalogued Marketplace
component for each capability (`marketplace-catalogue.md`); Build only with a reason in the
fit-gap row"*, written to `PROJECT.md`. Failure: an unattended run left it unasked, skipped the
fit-gap, and hand-wrote in Java an LLM call the GenAI modules provide.
Expand Down
26 changes: 25 additions & 1 deletion tests/wave2/test-stage-p.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
#
# Run it against the PRE-fix script too — that is the positive control. A suite that has
# only ever seen the fix cannot show that it discriminates. Expected on the pre-fix script:
# T2, T3, T5a, T5b, T6a, T8 and T10 fail.
# T2, T3, T5a, T5b, T6a, T8 and T10 fail. T12 reads bin/lib/intake-template.sh beside the
# gate; it fails on a template from before #766.
#
# tests/wave2/test-stage-p.sh /path/to/gate-check.sh
#
Expand Down Expand Up @@ -194,6 +195,29 @@ else
bad "missing intake message unhelpful: $V"
fi

echo "== T12: the auto-mode answer form is documented in the preamble, and passes (#766) =="
# An Interview mode: auto run wrote "Assumed (Interview mode auto)" answers, FAILed Stage P, and
# learned the accepted form only from the FAIL message. The preamble an auto-mode agent reads
# first must name the form, and a section answered in it must PASS. The template is read from
# beside the gate under test, so the master copy is the positive control.
TPL="$(dirname "$GATE")/lib/intake-template.sh"
if [ -f "$TPL" ] && ( . "$TPL" && mxtk_intake_template ) | sed '/^## /,$d' | grep -q 'Assumed (auto-mode):'; then
ok "intake preamble names the 'Assumed (auto-mode):' form"
else
bad "intake preamble does not name the 'Assumed (auto-mode):' form ($TPL)"
fi
P="$(mkproj t12)"
{ section '1. Entry mode?' 'Assumed (auto-mode): greenfield — rejected: requirements-driven.'
section '2. Which ERP?' 'Assumed (auto) — none.'
} > "$P/intake.md"
V="$(stagep "$P")"
if printf '%s' "$V" | grep -q 'FAIL' && printf '%s' "$V" | grep -q '2. Which ERP?' \
&& ! printf '%s' "$V" | grep -q '1. Entry mode?'; then
ok "'Assumed (auto-mode):' passes; the colon-less form still fails"
else
bad "auto-mode answer mis-graded: $V"
fi

echo ""
echo "PASS=$PASS FAIL=$FAIL ($WORK)"
[ "$FAIL" -eq 0 ]
Loading