Repository navigation
Conversation
…r copy (#765) An app built with the toolkit went live through a separate Team Server working copy with no .mxtk, so later changes skipped the exec gate, snapshots and BUILD-LOG unnoticed. - skills/platform-link.md §3: the "going live" rule plus a six-step recovery for a copy that already split off (mprname trap, ContentsHash, model-aware merge needs mxcli >= 0.30). - One-line pointers from conversion-runbook Stage 6 and deploy-to-sandbox. - bin/status.sh: WATCH (local git only, exit code unchanged) at Stage 6+ with no Team Server remote, and when a fetched Team Server ref is in no local branch. - tests/wave2/test-status-teamserver.sh: master 7/10, branch 10/10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE. It implements #765 options 1 + 2 as triaged: warn-only, using local git only. One minor point: a Stage 6/7 project that deliberately deploys outside Team Server gets a permanent "no Team Server remote" WATCH with no way to silence it. That is advisory, so it does not block. Value:
Regression risk:
Correctness: No bugs found.
Context cost: 66196 → 66217 always-loaded words (+21, measured). It is the runbook's Stage 6 line, read at the deploy moment. Time cost: per Conflicts: none with origin/master. It conflicts with #777 in Generated by Claude Code |
Fixes #765
Direct lane
What changed and why (one paragraph): A greenfield app built with the toolkit went live through a separate Team Server working copy with no
.mxtk. Every later change skipped the exec gate, snapshots and BUILD-LOG, and nothing on the toolkit side said so. This implements the triage comment's options 1 + 2, with the deploy check warning only; it never requires a remote.Option 1 (docs):
skills/platform-link.md§3 gets a "Going live: the toolkit project IS the Team Server copy" rule and a six-step Recovering a split-off Team Server copy recipe:git rm -rq mprcontents, then check it out from the Team Server copy. Themprname/App.mprtrap is noted here.mxcli fix hashes(ContentsHash goes stale after a checkout), thenmx check.-X oursand push without force.mx-metadata-note.py sync.The recipe adds that the model-aware merge path (both sides changed the model) needs mxcli ≥ 0.30 for
git merge(#741 research), and points toparallel-builds.md§4–5. One-line pointers go inconversion-runbook.mdStage 6, worded as "every entry mode" because greenfield skips Stage 7, and indeploy-to-sandbox.mdStep 1.Option 2 (warn):
bin/status.shadds two WATCH items:git.api.mendix.comorteamserver.ts-exportbranch from raising a false alarm.Both use local git only (
git config --get-regexp remote.*.url,for-each-ref,merge-base --is-ancestor): no network and no exit-code change. It reads the project root, plusapp/when that is its own repository (two-tree).Impact
bin/status.sh(brief and full screen) only when they fire. No new artifact.bin/status.sh(adds one block and one WATCH-loop entry);skills/conversion-runbook.md(baseline, one line);skills/platform-link.mdandskills/deploy-to-sandbox.md(on demand). The only reads are git config and refs, which exist in any repo, so there is no new producer. Git ≥ 2.7 is needed forfor-each-ref --contains. No GNU-only flags;check-portabilityis clean. Sharesbin/status.shwith #767's PR, so the two need a composition check.bin/render-routing.sh --checkon master and branch. Only the runbook line is baseline. Every stage that loads the runbook gets +21 for lead/ba/architect (for example Stage 6: lead 26,975 → 26,996). Stage 6 mdl/gate/test/review get +21 through the runbook slice (mdl 9,581 → 9,602, gate 21,952 → 21,973). Theplatform-link.mdanddeploy-to-sandbox.mdadditions are on demand. The 21 words are needed at the trigger moment: a Stage 6 session about to deploy is told not to make a second copy.status.shrun: per session, never per exec or build row. About 10 ms measured.Time cost: per session (status.sh) · ~0.01 s on a Linux container · can force rework: n · offset: maintainer OK
Field evidence: a greenfield build field report (2026-11-13, anonymised in #765) shows the defect: a second Team Server copy with no toolkit. The instrument has not run against a real Team Server project yet (no PAT here). Its inputs are git's own refs and config, which the fixture builds as real git objects in temp repos. The golden input is therefore real git state, not a hand-written parse. The first field run should be cited on the next project that goes live.
Fixture:
tests/wave2/test-status-teamserver.sh bin/status.sh. Cases:app/remote countsResults:
bin/status.sh: 7 passed, 3 failed (T1 no-remote warn, T4 ahead warn, T7 full-screen warn)Existing fixtures targeting
bin/status.sh, on the branch:test-status-existing-app: 27/27, including the byte-difftest-status-lint-unversioned: 4/4test-status-session-cwd: 10/10test-status-bare-var: 3/3 (T1–T2 SKIP, no ISO-8859-1 locale)Also clean:
bin/check-scripts.sh,bin/check-portability.sh,render-routing.sh --check, and the leak guard.check-portabilityis clean, and the code uses POSIX awk/grep/sed and only the git plumbing listed above.CHANGELOG.mdline appended under## Unreleased, crediting the greenfield field run of 2026-11-13Review: pending independent review
Generated by Claude Code