Skip to content

fix(tests): run-all.sh opens no browser tabs (MXTK_NO_GUIDE=1) - #779

Open
MendixMau wants to merge 1 commit into
masterfrom
fix/tests-no-guide-tab
Open

MendixMau wants to merge 1 commit into
masterfrom
fix/tests-no-guide-tab

Conversation

@MendixMau

Copy link
Copy Markdown
Owner

Direct lane

What changed and why (one paragraph): a local full run of tests/wave2/run-all.sh on macOS kept opening toolkit-guide.html in the real browser: every fixture that scaffolds a fresh project through bin/init-project.sh hits the first-touch auto-open, and only some fixtures set MXTK_NO_GUIDE=1. The runner now exports it next to MXTK_LEAKGUARD_DENYFILE. test-guide-reopen.sh unsets it, because it tests the opening itself with a fake open on PATH.

Impact

Row Answer
Process none
Dependencies none: no shared lib touched; tests only
Context cost none: no routed or always-loaded file touched
Behaviour n/a: scripts only
Runtime n/a (one env var)

Field evidence: local full suite on macOS opened a new guide tab per scaffolding fixture for the whole run. MXTK_NO_GUIDE=1 bash tests/wave2/test-guide-reopen.sh: 10/10 with this change; the pre-change test under the same env: 3 pass, 7 FAIL (so the unset is needed).

  • No client data anywhere in the diff
  • Size cap: 3 files, 8 lines
  • Test tier reached: T1, the affected fixture under the suite env plus a negative control; bash -n on run-all.sh
  • New/changed instrument: n/a
  • New skill: n/a
  • CHANGELOG.md line appended
  • Bug entries: n/a

🤖 Generated with Claude Code

…browser tabs

Every fixture that scaffolds through bin/init-project.sh opened toolkit-guide.html in the
developer's real browser. test-guide-reopen.sh unsets it: it tests the opening with a fake open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant