Repository navigation
Conversation
…browser tabs Every fixture that scaffolds through bin/init-project.sh opened toolkit-guide.html in the developer's real browser. test-guide-reopen.sh unsets it: it tests the opening with a fake open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane
What changed and why (one paragraph): a local full run of
tests/wave2/run-all.shon macOS kept openingtoolkit-guide.htmlin the real browser: every fixture that scaffolds a fresh project throughbin/init-project.shhits the first-touch auto-open, and only some fixtures setMXTK_NO_GUIDE=1. The runner now exports it next toMXTK_LEAKGUARD_DENYFILE.test-guide-reopen.shunsets it, because it tests the opening itself with a fakeopenon PATH.Impact
Field evidence: local full suite on macOS opened a new guide tab per scaffolding fixture for the whole run.
MXTK_NO_GUIDE=1 bash tests/wave2/test-guide-reopen.sh: 10/10 with this change; the pre-change test under the same env: 3 pass, 7 FAIL (so the unset is needed).bash -non run-all.shCHANGELOG.mdline appended🤖 Generated with Claude Code