Repository navigation
NGLASS-2330 fix: Remove whitespace from generated image names - #896
Merged
Merged
Conversation
afonsobspinto
marked this pull request as ready for review
November 8, 2026 16:59
filippomc
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and cause
The linting change in commit
9272369, included in #888, added spaces around the slash insideCHApp.image_name's multiline f-string:Those spaces became part of the generated image reference. Task-image names inherit the same prefix, so they were affected too.
MNP's CI picked up the change when it cloned the updated CloudHarness
developbranch. Skaffold then rejected the generated configuration withinvalid image "mnp / neuroglass": invalid reference format, before image builds or tests could run.Fix
Resolve the configured image name into a local variable first, then construct the reference on one line with the slash directly between the two components:
This restores valid references such as
mnp/neuroglassandmnp/neuroglass-generate-thumbnail, while preservingharness.image_nameoverrides and task-image suffixes.The change is limited to
CHApp.image_name.