Skip to content

NGLASS-2330 fix: Remove whitespace from generated image names - #896

Merged
filippomc merged 2 commits into
developfrom
codex/NGLASS-2330-skaffold-config
Nov 9, 2026
Merged

filippomc merged 2 commits into
developfrom
codex/NGLASS-2330-skaffold-config

Conversation

@afonsobspinto

@afonsobspinto afonsobspinto commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Problem and cause

The linting change in commit 9272369, included in #888, added spaces around the slash inside CHApp.image_name's multiline f-string:

<project>/<image>   →   <project> / <image>
mnp/neuroglass      →   mnp / neuroglass

Those spaces became part of the generated image reference. Task-image names inherit the same prefix, so they were affected too.

MNP's CI picked up the change when it cloned the updated CloudHarness develop branch. Skaffold then rejected the generated configuration with invalid image "mnp / neuroglass": invalid reference format, before image builds or tests could run.

Fix

Resolve the configured image name into a local variable first, then construct the reference on one line with the slash directly between the two components:

return f"{self.project.base_image_name()}/{name}"

This restores valid references such as mnp/neuroglass and mnp/neuroglass-generate-thumbnail, while preserving harness.image_name overrides and task-image suffixes.

The change is limited to CHApp.image_name.

@afonsobspinto afonsobspinto changed the title NGLASS-2330 fix: Generate valid Skaffold image and release names NGLASS-2330 fix: Remove whitespace from generated image names Nov 8, 2026
@afonsobspinto
afonsobspinto marked this pull request as ready for review November 8, 2026 16:59
@filippomc
filippomc merged commit 4a5ec53 into develop Nov 9, 2026
9 of 11 checks passed
@filippomc
filippomc deleted the codex/NGLASS-2330-skaffold-config branch November 9, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants