Repository navigation
fix(profile-sync-controller): send the enrollment's verification token when completing it - #10900
Merged
Merged
Conversation
…n when completing it
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
mathieuartu
enabled auto-merge
October 20, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Related to: https://consensyssoftware.atlassian.net/browse/MUL-2373
Checklist
Note
Medium Risk
Touches MFA enrollment auth paths and bearer token selection; wrong token handling could block factor setup or leak stale state, but scope is limited and well-tested.
Overview
Fixes
aal2_requiredfailures when finishing MFA enrollment (e.g. adding a second factor) by reusing the verification token frombeginCredentialEnrollmentoncompleteCredentialEnrollment, which the server now requires for both steps.AuthenticationControllerkeeps those tokens in memory per flow ID (including past the default enrollment session age and across OTP retries), drops them only after a successful complete, and clears them withclearVerificationSession.JwtBearerAuth.completeMfaEnrollmentgains an optionalaccessTokenoverride, wired through the SRP flow and covered by new controller/SDK tests.Reviewed by Cursor Bugbot for commit e761238. Bugbot is set up for automated code reviews on this repo. Configure here.