Repository navigation
test: use typed Vitest module mock factories - #10904
Merged
Merged
Conversation
4 tasks
cryptodev-2s
marked this pull request as ready for review
October 20, 2026 10:46
cryptodev-2s
enabled auto-merge
October 20, 2026 10:48
pedronfigueiredo
approved these changes
Oct 20, 2026
mm-confirmations-pull-request-bot
Bot
requested a review
from pedronfigueiredo
October 20, 2026 10:51
pedronfigueiredo
approved these changes
Oct 20, 2026
mathieuartu
approved these changes
Oct 20, 2026
adonesky1
approved these changes
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Use Vitest's module-promise overload for the remaining partial mock factories in keyring-controller, phishing-controller, and user-operation-controller. Partial factories receive the inferred
importOriginalhelper, removing the repeated module path and explicittypeof import(...)generic.References
Checklist
Note
Low Risk
Test-only mock setup refactors with no production code or runtime behavior changes.
Overview
This PR refactors partial
vi.mockfactories in controller test files to Vitest’s typed module-promise overload:vi.mock(import('…'), async (importOriginal) => ({ ...(await importOriginal()), … })).Affected tests:
uuidv4stub in keyring-controller, and@metamask/controller-utilspartial mocks (safelyExecuteWithTimeoutorquery) in phishing-controller and user-operation-controller. Behavior is unchanged—still spreads the real module and overrides specific exports—but drops duplicate module path strings and explicittypeof import(...)generics in favor of inferredimportOriginal. Follow-up to the same pattern used in #10871.Reviewed by Cursor Bugbot for commit a5b1baa. Bugbot is set up for automated code reviews on this repo. Configure here.