Repository navigation
fix!: Stop using wallet:eip155 as a wildcard - #4190
Merged
Merged
Conversation
Mrtenz
reviewed
Nov 18, 2026
Comment on lines
+66
to
+68
| accounts: accounts.map( | ||
| (account) => `${scope}:${account}`, | ||
| ) as CaipAccountId[], |
Member
There was a problem hiding this comment.
Nit: Slightly cleaner in my opinion.
Suggested change
| accounts: accounts.map( | |
| (account) => `${scope}:${account}`, | |
| ) as CaipAccountId[], | |
| accounts: accounts.map( | |
| (account) => `${scope}:${account}` as CaipAccountId, | |
| ), |
Member
Author
There was a problem hiding this comment.
The linter removed that as an unnecessary cast, that was my initial idea at first too
Member
There was a problem hiding this comment.
Weird. Does it work if you specify it as return type?
Suggested change
| accounts: accounts.map( | |
| (account) => `${scope}:${account}`, | |
| ) as CaipAccountId[], | |
| accounts: accounts.map( | |
| (account): CaipAccountId => `${scope}:${account}`, | |
| ), |
Mrtenz
approved these changes
Nov 18, 2026
FrederikBolding
force-pushed
the
fb/fix-preinstalled-snaps-middleware
branch
from
November 18, 2026 12:25
e151ddb to
72806fa
Compare
FrederikBolding
marked this pull request as ready for review
November 18, 2026 12:27
FrederikBolding
enabled auto-merge
November 18, 2026 12:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4190 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 429 429
Lines 12529 12541 +12
Branches 1986 1987 +1
=======================================
+ Hits 12365 12377 +12
Misses 164 164 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fact that
wallet:eip155was treated as a wildcard was a bug that was later fixed in the JSON-RPC pipeline. This means that the preinstalled Snaps middleware is currently broken. This PR aims to fix that by automatically granting all available scopes instead of using a wildcard.