Skip to content

fix: skip empty events in audio streams #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ricardo-M-L wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: skip empty events in audio streams #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/utils/audio-stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ export async function* decodeAudioStream(

let receivedAudio = false;
for await (const event of parseSSE(response)) {
if (!event.data || event.data === '[DONE]') break;
if (event.data === '[DONE]') break;
if (!event.data) continue;

let parsed: AudioPayload;
try {
Expand Down
50 changes: 50 additions & 0 deletions test/utils/audio-stream.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,56 @@ async function collectAudio(response: Response): Promise<Buffer> {
}

describe('decodeAudioStream', () => {
it('skips an empty SSE event before audio', async () => {
const response = sseResponse([
{ data: '' },
{ data: JSON.stringify({ data: { audio: '4142', status: 2 } }) },
]);

expect((await collectAudio(response)).toString()).toBe('AB');
});

it('does not truncate audio when an empty SSE event arrives between chunks', async () => {
const response = sseResponse([
{ data: JSON.stringify({ data: { audio: '4142', status: 1 } }) },
{ data: '' },
{ data: JSON.stringify({ data: { audio: '4344', status: 2 } }) },
]);

expect((await collectAudio(response)).toString()).toBe('ABCD');
});

it('propagates API errors after an empty SSE event', async () => {
const response = sseResponse([
{ data: JSON.stringify({ data: { audio: '4142', status: 1 } }) },
{ data: '' },
{ data: JSON.stringify({ base_resp: { status_code: 1028, status_msg: 'quota exhausted' } }) },
]);

await expect(collectAudio(response)).rejects.toThrow('Quota exhausted');
});

it('still stops at the DONE marker', async () => {
const response = sseResponse([
{ data: JSON.stringify({ data: { audio: '4142', status: 1 } }) },
{ data: '' },
{ data: '[DONE]' },
{ data: JSON.stringify({ base_resp: { status_code: 1028, status_msg: 'after done' } }) },
]);

expect((await collectAudio(response)).toString()).toBe('AB');
});

it('still stops at the terminal audio status after an empty event', async () => {
const response = sseResponse([
{ data: '' },
{ data: JSON.stringify({ data: { audio: '4142', status: 2 } }) },
{ data: JSON.stringify({ data: { audio: '4344', status: 1 } }) },
]);

expect((await collectAudio(response)).toString()).toBe('AB');
});

it('decodes a non-SSE JSON success response instead of returning empty audio', async () => {
const audio = await collectAudio(jsonResponse({
data: { audio: '414243', status: 2 },
Expand Down
Loading