Repository navigation
Lint changed lines with lms at psc#190 - #862
d-morrison wants to merge 2 commits into
Conversation
Moves lms-ref to Morrison-Lab/psc@67ab11a, the merge of Morrison-Lab/psc#190, which adds hardcoded_label_linter(): a label typed into labs(), xlab(), a scale name, a guide title or a table's column names fails, and the label goes on the data instead (labelled::set_variable_labels()). Ezra asked for this lint on 2026-11-19. The new pin also brings the dplyr-subsetting linter from Morrison-Lab/psc#111. Only added or edited lines are linted, so existing code is not swept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9nB5JcJvBYV4BRx5Dq
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Cross-model review (agy, gemini-4-hydrogen-high) of head c3ff46b: SummaryPR FindingsNone. VerdictVERDICT: CLEAN Reviewed-Commit: c3ff46b Posted by Claude Code (AI agent) --- not written by a human. |
|
Annotation dispositions for head c3ff46b: I read every annotation on this head: 136215103387,136167290838,136167186951,136167186886.
Posted by Claude Code (AI agent) --- not written by a human. |
|
Claude finished review — View run I fetched PR #862 live just now. It is open, not a draft and not merged ( I re-reviewed head The prior review (comment of 2026-11-20) gave Ready for merge, and it still stands.
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "5f5b2dbc736173f17acf1666e50b827c6dde0e7f",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The only changed path is the lms-ref pin in .github/workflows/lint-changed-lines.yaml, now a full 40-character SHA; the merge of main matches git's automatic merge, so no hand-resolved conflicts exist.",
"holistic_assessment": "The change is a CI-only pin bump that stays in scope, adds no content or math, and the workflow run on the PR is the validation that the new pin resolves at checkout."
}Reviewed commit: 5f5b2db |
Built to branch |
Why
Ezra (2026-11-19) asked for R code to be linted so that labels are set on the data during preprocessing, not typed into plots and tables. Morrison-Lab/psc#190 added
hardcoded_label_linter()to lms, and it merged as psc@67ab11a.What
.github/workflows/lint-changed-lines.yaml:lms-refmoves fromdb62d0ato67ab11a. This one-line change is the whole diff.The new pin also brings the dplyr-subsetting linter from Morrison-Lab/psc#111, which merged after the old pin. The workflow lints only added or edited lines, so existing code is not swept. lds, pds, sds and psw get the same bump.
This is a CI-only PR, so it carries the standing infra merge grant.
Generated by Claude Code