Skip to content

Lint changed lines with lms at psc#190 - #862

Open
d-morrison wants to merge 2 commits into
mainfrom
claude/lms-ref-labels
Open

d-morrison wants to merge 2 commits into
mainfrom
claude/lms-ref-labels

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Why

Ezra (2026-11-19) asked for R code to be linted so that labels are set on the data during preprocessing, not typed into plots and tables. Morrison-Lab/psc#190 added hardcoded_label_linter() to lms, and it merged as psc@67ab11a.

What

  • .github/workflows/lint-changed-lines.yaml: lms-ref moves from db62d0a to 67ab11a. This one-line change is the whole diff.

The new pin also brings the dplyr-subsetting linter from Morrison-Lab/psc#111, which merged after the old pin. The workflow lints only added or edited lines, so existing code is not swept. lds, pds, sds and psw get the same bump.

This is a CI-only PR, so it carries the standing infra merge grant.


Generated by Claude Code

Moves lms-ref to Morrison-Lab/psc@67ab11a, the merge of
Morrison-Lab/psc#190, which adds hardcoded_label_linter(): a label
typed into labs(), xlab(), a scale name, a guide title or a table's
column names fails, and the label goes on the data instead
(labelled::set_variable_labels()). Ezra asked for this lint on
2026-11-19. The new pin also brings the dplyr-subsetting linter from
Morrison-Lab/psc#111. Only added or edited lines are linted, so
existing code is not swept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9nB5JcJvBYV4BRx5Dq
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

link-checker fails, but not because of this PR. Both blocking errors are connection failures to web.stanford.edu, for the ~boyd/vmls and ~boyd/cvxbook links on pages this PR does not touch. This PR changes only .github/workflows/lint-changed-lines.yaml. pds and sds hit the same host at the same time, so the whole host is unreachable from the runners. I re-ran the job once (run 44700430813, attempt 2). The check should clear once Stanford's site is reachable again.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@d-morrison

Copy link
Copy Markdown
Contributor Author

Cross-model review (agy, gemini-4-hydrogen-high) of head c3ff46b:

Summary

PR Morrison-Lab/mds#862 updates lms-ref in .github/workflows/lint-changed-lines.yaml from db62d0af4b618da4691ffa5d97d2656c4b286dd9 to 67ab11a4dcfbd93684353d0a2e10c26a9d41e77f. From the provided title, description, and diff, the 40-character commit SHA, short prefixes (db62d0a → 67ab11a), YAML indentation, and target file path all match the PR description, with no defects found in the diff or text.

Findings

None.

Verdict

VERDICT: CLEAN

Reviewed-Commit: c3ff46b

Posted by Claude Code (AI agent) --- not written by a human.

@d-morrison

Copy link
Copy Markdown
Contributor Author

Annotation dispositions for head c3ff46b:

I read every annotation on this head: 136215103387,136167290838,136167186951,136167186886.

  • Link-checker warnings (Network error on web.stanford.edu URLs): no change. None of the flagged lines is in this diff. The diff changes only .github/workflows/lint-changed-lines.yaml. The cause is a host outage on web.stanford.edu, the same one seen on mds#862, pds#474 and sds#642 earlier. Since gha#2162, off-diff link failures are reported as warnings.
  • Notice, "PR edits workflow files; restored .github/workflows/ from the default branch": no change. This is expected for a PR that edits a workflow. The review ran with main's workflows, which is the safe path.
  • Notice, "SUBMODULES_TOKEN is empty; cloning submodules anonymously": no change. The submodules are public, and checkout succeeded.
  • Notice, "Skipping element-level diff highlighting" (element cap), where present: no change. This is only a limit on the render-diff display, and it doesn't affect the result.

Posted by Claude Code (AI agent) --- not written by a human.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR #862 live just now. It is open, not a draft and not merged (mergedAt is null). Its head is 5f5b2dbc736173f17acf1666e50b827c6dde0e7f, the commit I reviewed. So the review below still holds.

I re-reviewed head 5f5b2dbc736173f17acf1666e50b827c6dde0e7f. The PR is unchanged in substance from the round I reviewed before.

The prior review (comment of 2026-11-20) gave Ready for merge, and it still stands.

  • The diff: The PR's only change is one line in .github/workflows/lint-changed-lines.yaml. It moves lms-ref from db62d0a to the full 40-character SHA 67ab11a4dcfbd93684353d0a2e10c26a9d41e77f.
  • What changed since that round: The range holds only the merge of main. That merge matches git's automatic merge of its parents. Its 10 commits are already on main, so they are out of scope here.
  • Content and math: The PR adds no .qmd, _subfiles, R code or math. The content rules, the macro check and the line-break check have nothing to apply to.
  • Pin target: I did not re-verify that the SHA resolves in the repository the workflow checks out. The workflow run is the real check, because a bad pin fails at checkout.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "5f5b2dbc736173f17acf1666e50b827c6dde0e7f",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only changed path is the lms-ref pin in .github/workflows/lint-changed-lines.yaml, now a full 40-character SHA; the merge of main matches git's automatic merge, so no hand-resolved conflicts exist.",
  "holistic_assessment": "The change is a CI-only pin bump that stays in scope, adds no content or math, and the workflow run on the PR is the validation that the new pin resolves at checkout."
}

Reviewed commit: 5f5b2db

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2088 (review) — run

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/mds/pr-preview/pr-862/

Built to branch gh-pages at 2026-11-20 17:45 UTC.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants