Skip to content

Lint changed lines with lms at psc#190 - #474

Open
d-morrison wants to merge 2 commits into
mainfrom
claude/lms-ref-labels
Open

d-morrison wants to merge 2 commits into
mainfrom
claude/lms-ref-labels

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Why

Ezra (2026-11-19) asked for R code to be linted so that labels are set on the data during preprocessing, not typed into plots and tables. Morrison-Lab/psc#190 added hardcoded_label_linter() to lms, and it merged as psc@67ab11a.

What

  • .github/workflows/lint-changed-lines.yaml: lms-ref moves from db62d0a to 67ab11a. This one-line change is the whole diff.

The new pin also brings the dplyr-subsetting linter from Morrison-Lab/psc#111, which merged after the old pin. The workflow lints only added or edited lines, so existing code is not swept. lds, mds, sds and psw get the same bump.

This is a CI-only PR, so it carries the standing infra merge grant.


Generated by Claude Code

Moves lms-ref to Morrison-Lab/psc@67ab11a, the merge of
Morrison-Lab/psc#190, which adds hardcoded_label_linter(): a label
typed into labs(), xlab(), a scale name, a guide title or a table's
column names fails, and the label goes on the data instead
(labelled::set_variable_labels()). Ezra asked for this lint on
2026-11-19. The new pin also brings the dplyr-subsetting linter from
Morrison-Lab/psc#111. Only added or edited lines are linted, so
existing code is not swept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9nB5JcJvBYV4BRx5Dq
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

link-checker fails, but not because of this PR. Every blocking error is a connection failure to web.stanford.edu: 8 links on pages this PR does not touch, including cs109, stats116, ee278 and stats311. This PR changes only .github/workflows/lint-changed-lines.yaml. It failed the same way on the first run and on its one re-run (attempt 2 of run 44700442859), and mds and sds hit the same host at the same time. So the whole host is unreachable from the runners; nothing in this diff is broken. The check should clear once Stanford's site is reachable again.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@d-morrison

Copy link
Copy Markdown
Contributor Author

Cross-model review (agy, gemini-4-hydrogen-high) of head 16ea012:

Summary

This PR updates .github/workflows/lint-changed-lines.yaml in Morrison-Lab/pds by changing the lms-ref input from db62d0af4b618da4691ffa5d97d2656c4b286dd9 to 67ab11a4dcfbd93684353d0a2e10c26a9d41e77f. Based solely on the provided PR text and diff, the file path, full 40-character SHA, short prefixes (db62d0a and 67ab11a), commit URL, and one-line diff scope all match between the description and the diff, and YAML indentation is preserved.

Findings

None.

Verdict

VERDICT: CLEAN

Reviewed-Commit: 16ea012

Posted by Claude Code (AI agent) --- not written by a human.

@d-morrison

Copy link
Copy Markdown
Contributor Author

Annotation dispositions for head 16ea012:

I read every annotation on this head: 136215130342,136167319257,136167224946.

  • Link-checker warnings (Network error on web.stanford.edu URLs): no change. None of the flagged lines is in this diff. The diff changes only .github/workflows/lint-changed-lines.yaml. The cause is a host outage on web.stanford.edu, the same one seen on mds#862, pds#474 and sds#642 earlier. Since gha#2162, off-diff link failures are reported as warnings.
  • Notice, "PR edits workflow files; restored .github/workflows/ from the default branch": no change. This is expected for a PR that edits a workflow. The review ran with main's workflows, which is the safe path.
  • Notice, "SUBMODULES_TOKEN is empty; cloning submodules anonymously": no change. The submodules are public, and checkout succeeded.
  • Notice, "Skipping element-level diff highlighting" (element cap), where present: no change. This is only a limit on the render-diff display, and it doesn't affect the result.

Posted by Claude Code (AI agent) --- not written by a human.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


The only change in the PR is the lms-ref pin in .github/workflows/lint-changed-lines.yaml, which moves from one full 40-character SHA to another. The PR is open and its head is 5962d23ffaccc5bee2f298bc1bc465e85444f7d8.

The head differs from the previously reviewed 16ea012 only by a merge of main. That merge matches git's automatic merge of its parents, so nothing new needs review. The earlier review is at #474 (comment). It found no issues and gave "Ready for merge" provided lint-changed-lines passes, and that verdict still stands.

I could not check that the new lms-ref SHA exists, because the lms repository appears to be private. The lint-changed-lines check on this PR will fail if the SHA doesn't resolve. The diff adds no content or math, so the notes-content and macro checks don't apply.

Verdict

Ready for merge, provided the lint-changed-lines check passes.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "5962d23ffaccc5bee2f298bc1bc465e85444f7d8",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only change is the lms-ref pin in lint-changed-lines.yaml, swapped for another full 40-character SHA; the SHA could not be resolved because the lms repository is private, so CI must confirm it.",
  "holistic_assessment": "The change is scoped to one workflow input with no content or math, the head differs from the prior review only by a clean merge of main, and the lint-changed-lines run on this PR is the validation."
}

Reviewed commit: 5962d23

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1747 (review) — run

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/pds/pr-preview/pr-474/

Built to branch gh-pages at 2026-11-20 17:16 UTC.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants