Repository navigation
fix(probes): move tool_calling's simulated clock with the conversation - #163
Merged
3mei merged 1 commit intoNov 16, 2026
Conversation
The simulated service's clock stood at noon for the whole conversation and an identical call returned identical data, so a live score, a job's progress or a list of departures never moved however often the user asked. The simulator also read "nothing after the clock has happened" as nothing being scheduled, so showtimes two days ahead came back unpublished. The clock now reads noon UTC at the user's first message and moves two minutes with each one after, up to 12:59; each earlier call is listed with the time it was made, and what moves with time, such as a live score, a job's progress, stock or a price, may have moved since. An event after the clock has no result, score or reading yet, while what is planned for later, such as a schedule, a showtime, a listing, a forecast, a booking or a price, already exists, and the judge lets it stand. The tool_calling prompt version is v1.11. Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
None
What changed and why
tool_calling's simulated service keeps one clock, noon UTC, for a whole conversation, and an identical call returns identical data, so anything a user checks again never moves: a live score, a job's progress, the next departures. The simulator also reads "nothing after the clock has happened" as nothing being scheduled, so a schedule, showtime or listing for a later date comes back as not yet published.get_status({…}) at 12:02 UTC returned: …. An identical call still returns the same data, except that what moves with time, such as a live score, a job's progress, stock or a price, may have moved since. Within one turn the clock does not move, so calls in a turn agree.The
tool_callingprompt version isv1.11.How it was verified
New tests fail on the code before the change and pass after it: the clock at the first, second and fourth message and its stop at 12:59 (
test_probe.py), a call after the user's second message reading12:02(test_probe.py), earlier calls listed with their times and the rule on what moves (test_response_judge.py), and the wording on later events and plans in both prompts (test_response_judge.py).On the commit's own tree:
make check-all, the pre-commit hooks on its files andpytest --collect-only(5155 tests collected).At the head, on its exact tree in a fresh environment:
Live, against a custom provider config, on the head's code: the end-to-end health check with the
tool_callingprobe in English, and, on this branch before the last change to which tools get the user's records, the health check and onetool_callingrow simulated and evaluated with--scorers autoin English and Japanese:The same three calls, taken from earlier conversations, sent five times each through the simulator and its judge on the base branch and on this branch, against a custom provider config:
In 40 English and Japanese conversations on this branch, the judge rejected 9% of responses and left 8 unverified, against 11% and 8 in 40 conversations on the base branch, so data that moves between turns is accepted.
Results impact
tool_callingconversations from prompt versionv1.10are regenerated atv1.11. In a multi-turn conversation, a repeated call can now return data that moved, and a request for a later date's schedule, showtimes or listings gets them, so tool results and the assistant replies built on them change.