Repository navigation
Open
Labels
area:buildCI/CD workflows, releases, build targets, packaging, and artifact publication.CI/CD workflows, releases, build targets, packaging, and artifact publication.topic:dxMaking OpenShell easy to contribute to for humans and agents.Making OpenShell easy to contribute to for humans and agents.
Description
User Story
As an OpenShell maintainer reviewing pull requests, I need the maintainer change alert to describe changes that a PR would introduce to MAINTAINERS.md on main, so I can identify actual changes to the approval gate.
Problem Statement
The alert compares the PR target's file with the PR head's file and runs for PRs targeting any branch. It reported the addition of @FrostGod on #4606, #4607, and #5289 even though those PRs did not introduce that change to main. A PR behind main can also make a direct base-to-head comparison report removals that a merge would preserve.
Impact / Why This Matters
Incorrect alerts distract reviewers and can obscure real changes to the maintainer approval gate.
Acceptance Criteria
- Alert only for a PR targeting
mainwhose prospective merge changes the parsed maintainer list onmain. - Compare the target file with the prospective merge result so unrelated changes already on
mainare preserved. - If the prospective merge cannot be determined, fail without posting a misleading delta.
- Continue to report real additions and removals, including an unparseable resulting list.
- Existing comments do not need historical correction.
Reproduction Steps
- Inspect the maintainer alert comments on test(conformance): migrate create-upload tests to testkit #4606, test(conformance): migrate workspace lifecycle tests to workspace stories #4607, and chore(windows): sync main and restore native compatibility #5289, and their target branches when the alert ran.
- Compare the workflow's base and head file reads with the approval gate's use of
main.
Environment
- OpenShell repository GitHub Actions:
Maintainers Change AlertandMaintainer Approvalworkflows
Metadata
Metadata
Assignees
Labels
area:buildCI/CD workflows, releases, build targets, packaging, and artifact publication.CI/CD workflows, releases, build targets, packaging, and artifact publication.topic:dxMaking OpenShell easy to contribute to for humans and agents.Making OpenShell easy to contribute to for humans and agents.
Activity