Skip to content

fix(server): warn on dangling provider refs at startup - #4661

Open
ericcurtin wants to merge 2 commits into
NVIDIA:mainfrom
ericcurtin:fix/4657-dangling-provider-startup/ericcurtin
Open

ericcurtin wants to merge 2 commits into
NVIDIA:mainfrom
ericcurtin:fix/4657-dangling-provider-startup/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

A deleted provider no longer blocks gateway startup. The preflight warns and keeps validating.

Related Issue

Closes #4657

Changes

  • Preflight looks up each provider and warns per sandbox on missing ones.
  • Split load_provider_environment_record out of load_provider_environment_records to share the lookup.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Ran cargo clippy and the startup_preflight unit tests.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@johntmyers @elezar PTAL, and /ok to test 1ed3a28e09724eae20ff8ed886ff1cf641858ef3 if it looks good. Thank you!

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Copy link
Copy Markdown
Contributor Author

Merged main to fix conflicts. @johntmyers @elezar PTAL, and /ok to test 30c1f3b952de6bc334f529ed0338470e4daff6da if it looks good. Thank you!

@mavromixaliskoullis-beep

Copy link
Copy Markdown

Is ok

@mrunalp mrunalp added the test:e2e Requires end-to-end coverage label Oct 17, 2026
@mrunalp

mrunalp commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 30c1f3b

@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/4661 does not exist yet. A maintainer needs to comment /ok to test 30c1f3b952de6bc334f529ed0338470e4daff6da to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

E2E failures look unrelated to this change: k3s-ha pod gating timeout, ssh_host_identity container exit, and workspace operator lbl-sb1 already exists. Could a maintainer re-run the failed jobs? Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(server): report dangling provider references instead of failing startup

3 participants