Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
c42bcf9 to
1c13b86
Compare
1c13b86 to
e91c0cb
Compare
|
/ok to test e91c0cb |
|
e91c0cb to
358e545
Compare
7c9afea to
441bff5
Compare
|
— codex GPT-6 on behalf of Ralf — Completed a CodeRabbit sweep across #3317, #3318, #3319, #3321 and this PR, including collapsed review comments and the older findings here.
Every finding now has a reply. The Git-error fallback and docs-helper relocation were deliberately left unchanged, with the reasons recorded on #3318 and #3319. Broader optional cache and artifact-payload validation work remains deferred: CI does not enable that cache, and baseline reuse already verifies the producer, exact commit and required artifacts. Validation: Full pre-commit checks (including workflow linting), focused trigger/stdin/permission and matrix-selection checks, and an independent patch review passed. The release path was also exercised by the two tag-triggered producer runs and eight successful release rehearsals completed before this sweep. CI results are tracked in the PR checks. |
|
/ok to test 441bff5 |
441bff5 to
0fabbbb
Compare
|
/ok to test 0fabbbb |
0fabbbb to
137ca2f
Compare
|
/ok to test 137ca2f |
137ca2f to
916db96
Compare
|
/ok to test 916db96 |
916db96 to
ec30734
Compare
|
/ok to test ec30734 |
|
— codex GPT-6 on behalf of Ralf — Release rehearsal results — November 7All eight release dry runs passed. Two real tag-triggered CI runs supplied the new CUDA 12/13 artifacts; both tags point to the same candidate commit, based on this stack snapshot.
Artifact checks covered 112 wheels, source archives and docs bundles containing 3,926 versioned HTML pages: versions/dependencies, complete wheel sets and archive contents. Automatic run lookup selected the matching tag; a successful CUDA 13 run was rejected for CUDA 12 despite their identical source SHA. The CUDA 13 producer passed on its first attempt. The CUDA 12 producer passed after one failed-jobs rerun for a Windows free-threaded crash and a WSL pyperf error. These dry runs published no packages, GitHub Releases, release assets or documentation. Core and Pathfinder used retained source/artifacts; fresh Core-tag production and actual publishing authorization/deployment remain untested. Subsequent changes leave release selection and publishing unchanged. The source/workflow revision boundary in toolkit setup was checked separately: current/historical helper selection, pinned public metadata for Linux/Windows selections, and Linux archive installation/cache restore all passed. |
|
— codex GPT-6 on behalf of Ralf — Mike, all five active PR CIs are now green. Here is the delta since your November 6 review of #3319. Changes since the November 6 review
Full CI: #3317, #3318, #3319, #3321, #3322. Your review comments have direct replies. The Core-build extraction remains a post-migration follow-up in #3402. |
|
This is mostly about feedback on #3321, but logging the high-level assessment here: codex GPT-6.1-Sol ultra: Mike has approved #3318 and #3319. His #3321 review raises three major issues and 13 inline comments. There is no published #3322 feedback yet. The nightly increase is real, and I recommend undoing the broad expansion. For a normal scheduled run using the committed matrix:
That is 68% more jobs and 76% more GPU-test jobs. These are configured job counts, not measured GPU-hours. Eight integration callers now run a second, standard-mode pass; the H200 expansion adds another GPU job and matrix-computation job. Production workflow, current workflow. The important correction is that production My recommended next steps:
I would keep this cleanup in #3321, propagate it into #3322, and leave the approved lower layers unchanged. Validate old/new behavior locally—including actual legacy callers—before one CI refresh for the affected upper PRs. The replies and descriptions should explicitly correct our earlier nightly-coverage rationale and report the resulting job counts. |
ec30734 to
4e7cd5b
Compare
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
4e7cd5b to
de242ab
Compare
— codex GPT-6 on behalf of Ralf —
Layer 7 of 7 of the staged "CUDA 12 bindings on
main" stack. Previous: #3321. Stack map at the bottom.What this PR does
Removes what the previous six layers made obsolete, and writes down how the two roots are maintained from now on.
ci/versions.ymlmoves to schema 2:cuda.bindings.package_rootswithtoolkit_versionandrelease_status;backport_branch,cuda.build, andcuda.prev_buildare gone.bindings_config.pystill reads the old format, because nightly may point at an older artifact source and release dry runs may point at retained CUDA 13 tags.check-bindings-config: each root's setuptools-scm selector must bev<major>.*for its CUDA major, the metapackage selector table must agree, and Core's cu12/cu13 bindings floors must not exceed the pinned toolkits. The old floor hook intoolshed/is narrowed to extras and docs.backport.ymlbecomes manual-only: a merged PR number plus an existing target branch, with validation. No more automatic backports on theto-be-backportedlabel. Dependabot's12.9.xentry is removed.ci-nightly.ymlextracts onlyci/versions.ymlfrom the artifact-source archive: schema-2 sources take the new route, older sources the legacy route (legacy-backport-branch). The legacy artifact aliases (cuda-python-wheel,<core artifact>-tests) are no longer produced.CONTRIBUTING.md(selector table, transferring a fix between roots withgit format-patch --relativeandgit am --directory, CUDA-major artifact flow, release branches),ci/README.md(registry, SCM milestones, nightly rollout, how to read CI job names, historical reruns, maintaining both roots, changing the supported lines),AGENTS.md(SYNCED blocks),cuda_bindings_12/MAINTENANCE.md(new), install page driver baseline correction (Linux 525.60.13, Windows 528.33), CI diagram.After this merges
12.9.xbranch is frozen except for emergency fixes; routine CUDA 12 work happens incuda_bindings_12/onmain.v12.9.11a0milestone is already on main; both alternatives are restacked onto it and contain no temporary SCM bootstrap.mainrun succeeds.Where to look
ci/versions.yml: the final registry, 19 lines.ci/tools/bindings_config.py:check_package_metadata()andcheck_core_toolkit_floors()..github/workflows/backport.ymlandci-nightly.yml.ci/README.md, section "Maintaining Both Bindings Roots": the policy reviewers are really approving.All changes (36 files, +977 / -377)
Config and hooks:
ci/versions.yml,.pre-commit-config.yaml(new hook; floor hook narrowed),ci/tools/bindings_config.py(metadata checks),toolshed/check_cuda_core_bindings_floor.py,cuda_core/cuda/core/_bindings_floor.py(comment),cuda_core/tests/test_bindings_floor.py,ci/tools/tests/test_bindings_metadata.py(new),ci/tools/check_pixi_cuda_version.py,ci/tools/tests/test_bindings_config.py.CI workaround:
cuda_core/tests/test_memory.pyruns supported pool-trim cases serially for the known driver synchronization issue #3350.Workflows:
backport.yml,.github/dependabot.yml,ci-nightly.yml,coverage.yml(registry-driven),build-wheel.yml(aliases removed),test-wheel-linux.yml,test-wheel-windows.yml(legacy-backport-branchinput).Docs:
AGENTS.md,CONTRIBUTING.md,README.md,ci/README.md,ci/ci-pipeline.mmd,.github/RELEASE-bindings.md,cuda_bindings_12/{AGENTS.md,MAINTENANCE.md,README.md,docs/README.md,docs/source/contribute.md,docs/source/install.md,docs/source/release/12.X.Y-notes.rst},cuda_bindings_13/{AGENTS.md,README.md,docs/README.md,docs/source/install.rst,docs/source/support.rst},cuda_core/AGENTS.md.Validation
main).126ed74fb5bbfbc91a04e50557cf936efef4da7f.Stack map: what
maincan do after each layer mergesmain...v12.*tagcuda_bindings_12/; the PR-time CPU source-build smoke covers both roots; three CUDA 12 runtime fixes are incuda.coreand the metapackage still consume12.9.xartifacts12.9.xbranchv12.9.Ntag onmain; CUDA 13 releases are unchanged12.9.xis frozenEvery layer was designed to be mergeable on its own and had a green full CI run at its pre-rebase head on 2026-10-31. The stack is the "individually mergeable pieces" alternative to #3174-#3182; both stacks reach the same end state except that this one keeps compatibility routes for older artifact sources and retained CUDA 13 tags.