Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originally this branch adapted the bundle to
roach-php/core 3.2+ Symfony^7.0(registeringHttpErrorMiddleware/ProxyMiddleware). It now also adds forward support for Symfony 8.x without any code changes:symfony/*: ^7.0 → ^7.0|^8.0(require+require-dev).ItemNormalizer::getSupportedTypes(): it returned a list ([ItemInterface::class]) instead of a keyed map ([ItemInterface::class => true]), so the Symfony serializer never associated the normalizer withItemInterfaceandroach:run --outputfailed withNotNormalizableValueException.#[Small]/#[Medium]/#[DataProvider]attributes;SymfonyExtensioninstead of the removedSymfonyTestsListener).php 8.2–8.5 × SYMFONY_REQUIRE 7.4.*/8.0.*/8.1.* × prefer-lowest/prefer-stable; drop the obsolete psalm step.Compatibility
No code changes are needed for Symfony 8: all Symfony classes imported by
roach-php/core+ this bundle exist in Symfony 8.1, and static analysis reports noundefined/not founderrors. The bundle stays a thin wrapper (boot()→Roach::useContainer()).Testing
prefer-lowest/prefer-stable).Notes for maintainers
The bundle alone cannot be installed on Symfony 8.x yet:
roach-php/core 3.2.1requiressymfony/* ^7.0(console, css-selector, dom-crawler, event-dispatcher, options-resolver) andphp ~8.2.0||~8.3.0||~8.4.0. Since this is a transitive constraint it cannot be patched after install — a matching constraint widening inroach-php/coreis required first. For that reason the8.0.*/8.1.*CI cells are marked as allowed failures until core is updated upstream.