You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue: what happens when the volume isnt a whole number of gb, like a root disk from a 2.2 gb template? resize only takes whole numbers so hitting ok without touching the size looks like it fails
Fix: Leave 2.2 visible in the Size field. If the user does not change it, do not include that value in the submit. The current disk size is then left as it is, so a 2.2 GB disk and an IOPS-only change both succeed. If the user enters a new whole-GB size, send that value.
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Major
Minor
Bug Severity
BLOCKER
Critical
Major
Minor
Trivial
Screenshots (if appropriate):
How Has This Been Tested?
Created a VM with root volume, having size same as template 3.5 GB
1- Click Resize, change only IOPS, did not change the size (3.5GB) - success
2- Click Resize, change size 3.5GB to 4 GB - success
3- Click Resize, no change at all - success
How did you try to break this feature and the system with this change?
@suryag1201 the screenshot alone might confuse the reviewer. If possible, capture images for everything you mentioned under How Has This Been Tested? section, and add some explanation to the screenshot that you added here, when you cherry-pick this to upstream.
@suryag1201 the screenshot alone might confuse the reviewer. If possible, capture images for everything you mentioned under How Has This Been Tested? section, and add some explanation to the screenshot that you added here, when you cherry-pick this to upstream.
@sandeeplocharla this came as a upstream PR review comments and they have the context and comments are also present on community PR. And, there is no much UI change which can be captured as a screenshot here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: what happens when the volume isnt a whole number of gb, like a root disk from a 2.2 gb template? resize only takes whole numbers so hitting ok without touching the size looks like it fails
Fix: Leave 2.2 visible in the Size field. If the user does not change it, do not include that value in the submit. The current disk size is then left as it is, so a 2.2 GB disk and an IOPS-only change both succeed. If the user enters a new whole-GB size, send that value.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Created a VM with root volume, having size same as template 3.5 GB
1- Click Resize, change only IOPS, did not change the size (3.5GB) - success
2- Click Resize, change size 3.5GB to 4 GB - success
3- Click Resize, no change at all - success
How did you try to break this feature and the system with this change?