Skip to content

Shop Pay: set Shopify to capture at checkout - #72

Open
next-devin wants to merge 2 commits into
mainfrom
shop-pay-capture
Open

next-devin wants to merge 2 commits into
mainfrom
shop-pay-capture

Conversation

@next-devin

Copy link
Copy Markdown
Contributor

NEXT doesn't yet capture Shop Pay payments on fulfillment or after a delay, as it does for gateways. A merchant whose Shop Pay store captures Manually would lose any order they don't capture by hand within 7 days.

Changes

  • New setup step, Capture payments at checkout: in Shopify admin, set Settings > Payments > Payment capture method to Automatically at checkout. It includes a warning about what happens with Manually.
  • "Managing Shop Pay Orders" no longer says payments are always authorized and captured later. It now explains both settings.

Remove the warning once NEXT auto-captures Shop Pay payments.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
nextcommerce-docs 5f3f172 Commit Preview URL

Branch Preview URL
Oct 21 2026, 10:13 AM

Comment thread content/docs/features/payments/shop-pay.mdx
Comment thread content/docs/features/payments/shop-pay.mdx Outdated
@kilo-code-bot

kilo-code-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • content/docs/features/payments/shop-pay.mdx

Notes

  • Both previous findings are resolved in the incremental commit 5f3f172: line 37 now reads "as it does for gateway payments" (ambiguous pronoun removed) and is split into two sentences; line 101 now uses "is set to capture Manually", matching the warning callout.
  • The warning callout, the setup step, and the "Managing Shop Pay Orders" paragraph consistently reference the same Shopify Payment capture method setting.
  • Docs-only change; no security, runtime, or API-impact concerns.
Previous Review Summary (commit 24ca368)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 24ca368)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
content/docs/features/payments/shop-pay.mdx 36 Ambiguous "it" in "the way it does for gateways" + comma splice in "each payment is only authorized, and you must capture it within 7 days"
content/docs/features/payments/shop-pay.mdx 101 Inconsistent phrasing with the callout: "captures manually" vs "is set to capture Manually"
Files Reviewed (1 file)
  • content/docs/features/payments/shop-pay.mdx - 2 issues

Notes

  • The change correctly adds a setup step for the Shopify capture-method setting and removes the now-incorrect blanket statement that Shop Pay payments are always authorized at checkout and captured later.
  • The new section placement under ## Shop Pay Requirements matches the surrounding Shopify admin setup flow (Sign up → Activate Shopify Payments → Capture method → Add domain → Copy credentials).
  • Cross-references between the setup step (line 33, "Under Payment capture method"), the warning callout (line 36, "is set to capture Manually"), and the managing-orders paragraph (line 101) all align on the same Shopify setting.
  • No security, runtime, or API-impact issues found; this is a docs-only change.

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 21.5K · Output: 645 · Cached: 95.1K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant