Repository navigation
fix(notifications): stop a late mark-all-read result from panicking - #12
Open
laksamanakeris wants to merge 1 commit into
Open
laksamanakeris wants to merge 1 commit into
laksamanakeris wants to merge 1 commit into
Conversation
use_action runs its future on a scope-bound task and cancels the running one on every new call. For a seam write, a second Save can drop a write that already reached the server and then send it again. The existing scan for scope-bound spawn cannot see it, because the spawn is inside the hook. Writes use spawn_forever and report into root-scope state.
laksamanakeris
force-pushed
the
fix/write-back-after-unmount
branch
from
November 4, 2026 10:52
d4c0d4d to
84fc731
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
try_write. Before, a result that arrived after the popover closed panicked on the dropped signal.ValueDroppedError.use_actionin views, components and modals.Why
use_actioncancels its running task on every new call. For a write, a repeated Save can drop a write that already committed and send it again.Checks
cargo fmt,cargo clippy -D warnings,cargo nextest: 269 passed.use_actionreference and names the file and line.