Repository navigation
revert: drop the steer secret-card fix, upstream #34634 covers it - #81
Merged
OmarAlex24 merged 4 commits intoNov 17, 2026
Merged
Conversation
…abel file The desktop no longer sends its display name to the server. A renamed build, like t3code-diy's side-by-side app, writes `environment-label` in its T3 home, which the server already reads for sandboxes. T3CODE_DESKTOP_DISPLAY_NAME still names the app's windows and About panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sandbox cases appended to upstream test files move to sibling *.sandbox.test.ts files, so those upstream files match upstream again and stop conflicting on the nightly rebase. The environment label no longer needs Path, so ServerEnvironmentLabel.test.ts stays identical to upstream. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The sandbox sections move from remote-access.md, which now matches upstream, to sandboxes.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rs it This reverts commit a21d203. Upstream pingdotgg#34634 fixes the same bug, and this copy would conflict with it in Orchestrator.ts once it merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OmarAlex24
changed the base branch from
docs/sandboxes-page
to
feat/sandbox-environments
November 17, 2026 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream pingdotgg#34634 fixes the same bug as the fork's "a steer no longer leaves a secret card nobody can close", and a maintainer is taking it over. Our copy would conflict with it in
Orchestrator.tsonce it merges.This is a plain
git revertof the squashed steer commit. Until pingdotgg#34634 lands, the bug comes back: a steer can leave a secret card nobody can close. The full fix is kept inarchive/sandbox-environments-pre-squash-20261117.After the revert,
SecretRequests.ts,SecretRequests.test.ts,SteeringCompletion.integration.test.tsandMcpHttpServer.test.tsmatch upstream.Orchestrator.tskeeps only sandbox hunks, which belong to the sandbox commit: the bridge imports,isStaleSandboxBridgeRun, the switch refusals off the sandbox bridge, held-run cancellation, and the launch wait inprepared-run.retry.Test plan
vp test runonSecretRequests.test.ts,SteeringCompletion.integration.test.tsandMcpHttpServer.test.ts: 126 passedgit diff upstream/mainon the four files above is emptyOpus 5.5 (claude-opus-5-5) in Claude Code, via T3 Code.
🤖 Generated with Claude Code