Repository navigation
OpenConceptLab/ocl_issues#2885 | AutoMatch in the strings oclmap#93 added - #95
Merged
Merged
Conversation
…dded oclmap#93 (ocl_issues#2865) merged the same morning as oclmap#94 and added strings that still said "Auto Match" or 自动匹配, which #94's branch never saw: the rate-limit notices in en, es, zh and pt-BR, and six pt-BR notices (throttled rows, no algorithms, blocked runs, nothing to run). closes OpenConceptLab/ocl_issues#2885 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Codex review, pass 1 (codex-cli 0.161.0, commit 1ffb7cb)Verdict: clean. No findings. findings.json{"reviewer":"codex-cli 0.161.0","perspective":"defects","mode":"full","commit":"1ffb7cb8d8a52fb69d796db69b677a6028cd94bb","verdict":"clean","prior":[],"findings":[]} |
Member
Author
|
Simplification review (fresh Claude subagent): clean, nothing to cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to oclmap#94. Closes OpenConceptLab/ocl_issues#2885.
oclmap#93 (ocl_issues#2865) merged the same morning as #94 and added strings that still call the feature "Auto Match" (自动匹配 in zh). #94's branch predates them, so it merged cleanly without catching them. This fixes the 14 that remain:
auto_match_rows_rate_limited,auto_match_rows_rate_limited_logauto_match_rows_throttled,auto_match_no_algorithms,auto_match_no_runnable_algorithms,auto_match_blocked_no_algorithms,auto_match_blocked_no_step,auto_match_nothing_to_runCatalogs only; no keys change. After this, no oclmap catalog string names the feature anything other than AutoMatch.
Checks: eslint (CI's command) is clean, and
npm run test:allpasses (453 tests).🤖 Generated with Claude Code