Repository navigation
🏷️🚮：drop the CC icons nothing includes - #1876
Merged
Merged
Conversation
Sixteen icons sat in the directory and four were ever included: the CC logo, BY, NC and SA, which is what the two licenses the documentation carries are spelled out of. The other twelve, 14,675 bytes of them, had no path in. Nothing reaches them dynamically. Every include in the site names its file literally, so an unreferenced icon is unreachable rather than merely unused today. `COPYING.md` stays. It states the trademark terms for the directory rather than for a list of files, and the four that remain are covered by it exactly as before. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (12)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
DerekNonGeneric
added
the
🚀 Status: Commit Queue
openinf-commit-queue
Bot
removed
the
🚀 Status: Commit Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixteen Creative Commons icons were in
_includes/assets/img/cc/. Fourare included anywhere:
cc-logo.svg_layouts/docs.liquidcc-by.svg_layouts/docs.liquidcc-nc.svg_layouts/docs.liquid, on non-handbook pagescc-sa.svg_layouts/docs.liquidThose four spell out the two licenses the documentation carries — BY-SA
in the handbook, BY-NC-SA everywhere else. The remaining twelve, 14,675
bytes, had no path in:
cc-heart,cc-heart-filled,cc-nc-eu,cc-nc-jp,cc-nd,cc-pd,cc-pdm,cc-remix,cc-sampling,cc-sampling-plus,cc-share,cc-zero.Nothing reaches them dynamically — every
{% include %}in the sitenames its file literally, so an unreferenced icon is unreachable rather
than merely unused today. If a page ever needs one, it is in this
repository's history and at creativecommons.org.
COPYING.mdstays: it states the trademark terms for the directoryrather than for a list of files, and covers the four that remain
exactly as before.
Checked
nps test— all verify tasks pass.counted in the built HTML: 3 in
doc-ccon a handbook page(logo, BY, SA), 4 on a non-handbook page (logo, BY, NC, SA).