Repository navigation
🏗️🔧:make the queue say why it could not start - #1882
Conversation
Every step that reports back to a pull request is gated on the app token, because reporting takes one. So a token that never minted reports nothing at all: a bare red check, no comment, and the label still sitting there as though the queue had yet to look. The queue works here today -- it has landed everything on this branch for weeks, and no landed pull request is left wearing the label -- so this is insurance rather than a repair. It stops being insurance the day the private key is rotated, the app is uninstalled from this repository, or a secret is cleared, and on that day the only signal is a red check with nothing to read. An annotation needs no token and no permission, so it is the one report that survives having no credentials at all. It names both causes and says the label has to come off by hand, since `unlabeled` is not a trigger and reapplying it would otherwise start nothing. The note above the two reporting steps also claimed they need only the app's pull request permission. They do not: labels and comments are issue endpoints even when the number belongs to a pull request, so they need `Issues: write`. This app satisfies it, which is exactly the case the note warns about two lines earlier -- tightening the permissions would break both behind the `|| true`. Ported from OpenINF/.github#896, where the file is byte-identical. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe commit queue workflow documents its required ChangesCommit queue workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The workflow adds credential-independent failure reporting and clarifies the permission required for queue label and comment operations. No current merge-readiness risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Yes — the same gap is here, in a file that is byte-identical to the
one in
OpenINF/.githubbefore#896 fixed it.
The gap
Both steps that report back to a pull request are gated on the app token:
They have to be — reporting takes a token. But a token that never mints
therefore produces a bare red
Landcheck, no comment, and the labelstill sitting on the pull request as though the queue had not looked.
How much it matters here, honestly
Less than it does in
.github, and I checked rather than assuming:liveforweeks, most recently 🏗️🔧:quote paths, read JSON5, fix the EC binary #1881.
🚀 Status: Commit Queue, which means the app really does hold thepermission that endpoint needs.
So this is insurance, not a repair. It stops being insurance the day the
private key is rotated, the app is uninstalled from this repository, or
a secret is cleared — and on that day the only signal is a red check
with nothing to read.
Also: a comment that is wrong
The note above those steps claims they "need only the pull request
permission the app already has". They do not — labels and comments are
issue endpoints even when the number belongs to a pull request, so they
need
Issues: write, per GitHub's permissions reference.This app satisfies it, which is precisely the case the note warns about
two lines earlier: "tightening its permissions … would break these
silently behind the
|| true." Someone acting on the wrong sentencewhile tightening the app is how that happens.
No permissions change. The job keeps
contents: read; wideningGITHUB_TOKENjust to post a failure comment is a larger surface thanthis warrants on a
pull_request_targetworkflow.Summary by CodeRabbit