Repository navigation
🏗️🔧：refuse a squash-style (#123) subject suffix - #1925
Conversation
The subject check refused a pull request number written as ` #123` but let through ` (#123)`, which is the form GitHub itself appends when it squashes a pull request. The handbook and the pull request templates both say the subject carries no number, since `PR-URL:` already records it. Refuse a trailing `(#123)` as well, with the same message, and add a test for it. Commits written by bots, such as Renovate's squashed `(#N)` subjects, are still skipped before this check runs. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly describes the main change: rejecting squash-style "(#123)" commit-subject suffixes. It is concise and specific, although the emoji prefix is unnecessary. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
@coderabbitai review Generated by Claude Code |
✅ Action performedReview finished.
|
DerekNonGeneric
added
the
🚀 Status: Commit Queue
Claude
openinf-commit-queue
Bot
removed
the
🚀 Status: Commit Queue
Requested by DerekNonGeneric · project thread
Before: the commit subject check rejected
fix the thing #123, butfix the thing (#123)got through. That second form is the one GitHub itself appends when it squashes.After: both forms are rejected with the same message, which says
PR-URL:carries the number.How: a one-line regex change in
build/shared/commit-message.mts, plus a test that fails without it. The same change goes to the other two copies in OpenINF/sdk and OpenINF/.github, so all three stay byte-identical. Bot-authored commits are skipped before this check runs. verify-unit (191/191) and the build pass. Locally,nps testfails only on the dprint and editorconfig-checker tasks, because those tools aren't installed in this sandbox.Summary by CodeRabbit
#123and(#123)formats, and provides the existing guidance.