Repository navigation
Refuse to migrate a database with an unrecognized schema version - #497
Open
tonygermano wants to merge 1 commit into
Open
tonygermano wants to merge 1 commit into
tonygermano wants to merge 1 commit into
Conversation
ServerMigrator treated a SCHEMA_INFO version it could not find in the Version enum the same as an empty table, and started the migration chain at V0. Startup then failed in the first legacy delta script (derby-0-1.sql or its equivalent) with an error that says nothing about the real problem. On a stock schema that script fails at its first statement, but nothing guarded the path: had a step succeeded, updateVersion() would also have seen no current version and inserted a second SCHEMA_INFO row. Stop with a MigrationException that names the version found, before any migrator runs. An empty SCHEMA_INFO table still starts at V0 as before. Fixes OpenIntegrationEngine#496. Issue: OpenIntegrationEngine#496 Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
kpalang,
mgaffigan,
pacmano1 and
ssrowe
October 17, 2026 07:15
mgaffigan
approved these changes
Oct 17, 2026
pacmano1
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerMigrator treated a SCHEMA_INFO version it could not find in the Version enum the same as an empty table, and started the migration chain at V0. Startup then failed in the first legacy delta script (derby-0-1.sql or its equivalent) with an error that says nothing about the real problem. On a stock schema that script fails at its first statement, but nothing guarded the path: had a step succeeded, updateVersion() would also have seen no current version and inserted a second SCHEMA_INFO row.
Stop with a MigrationException that names the version found, before any migrator runs. An empty SCHEMA_INFO table still starts at V0 as before.
Fixes #496.