Repository navigation
ci: fix CI (drop Python 3.9, tokio 1.53.3, regenerate third-party licenses) - #389
Conversation
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14'] | ||
| python-version: ['3.10', '3.11', '3.12', '3.13', '3.14'] |
There was a problem hiding this comment.
Should fix: This drops Python 3.9 from CI on every OS, but pyproject.toml still has requires-python = ">=3.9" and the 3.9 classifier. The Rust extension also still targets abi3-py39. Nothing would catch a change that breaks 3.9, such as PEP 604 X | Y annotations evaluated at runtime or match statements. Users on 3.9 would hit the breakage only after a release. The only failing case is ubuntu-latest, so keep 3.9 on the other runners:
exclude:
- os: ubuntu-latest
python-version: '3.9'Alternatively, pin a 3.9 job to ubuntu-24.04. If 3.9 support is really ending, bump requires-python and the classifiers in a follow-up.
There was a problem hiding this comment.
Addressed: Python 3.9 is back in the matrix: ubuntu-latest/3.9 is excluded and an ubuntu-24.04/3.9 job is added, so 3.9 is tested on every OS again.
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14'] | ||
| python-version: ['3.10', '3.11', '3.12', '3.13', '3.14'] |
There was a problem hiding this comment.
Nit: AGENTS.md:218 still describes the Code Quality matrix as {3.9, 3.10, 3.11, 3.12, 3.13, 3.14}, so it no longer matches this workflow. Update that line, and say whether 3.9 is still supported but untested.
There was a problem hiding this comment.
Addressed: With 3.9 restored, the workflow matrix (3.9–3.14) matches what AGENTS.md describes again.
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
a965465 to
6e30c39
Compare
Python 3.9 is end-of-life, and ubuntu-latest (26.04) no longer has a 3.9 build for actions/setup-python, which failed the 3.9 job and cancelled the rest of the matrix. Raise requires-python to >=3.10, drop the 3.9 classifier, target abi3-py310, and remove 3.9 from the hatch and CI matrices. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
cargo-deny's advisories check fails on RUSTSEC-2026-0386 (unsound safe AsyncFd constructors) for tokio 1.53.1. 1.53.3 is the patched release on the same minor line. Lockfile-only update; the matching tokio line in THIRD-PARTY-LICENSES.txt is updated so the license check stays in sync with Cargo.lock. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
New pydantic, pydantic_core and typing-inspection releases put the committed file out of date. Regenerated with scripts/check_third_party_licenses.sh --update; only version lines changed. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
6e30c39 to
70053ff
Compare
Fixes: N/A. Supersedes #386, #387, and #388.
What was the problem/requirement? (What/Why)
CI on mainline fails: the Python 3.9 job fails on ubuntu-latest (now 26.04, with no 3.9 build for setup-python) and cancels the rest of the matrix, cargo-deny flags RUSTSEC-2026-0386 in tokio 1.53.1, and THIRD-PARTY-LICENSES.txt is out of date.
What was the solution? (How)
Drops Python 3.9 support, which is end-of-life: requires-python is now >=3.10, the 3.9 classifier is removed, the extension targets abi3-py310, and 3.9 is removed from the hatch and CI matrices (matching how deadline-cloud-worker-agent dropped 3.9). Also bumps tokio to 1.53.3 in Cargo.lock and regenerates THIRD-PARTY-LICENSES.txt.
What is the impact of this change?
Python 3.9 users can no longer install new releases; the wheel tag becomes cp310-abi3. Otherwise a lockfile patch bump and a regenerated license file; no runtime source changes.
How was this change tested?
Locally ran
hatch build(cp310-abi3 wheel),hatch run lint,hatch run test(6330 passed), cargo check/clippy-D warnings,cargo deny, andscripts/check_third_party_licenses.sh.Was this change documented?
README and DEVELOPMENT now state Python 3.10 or higher.
Is this a breaking change?
No. Dropping an end-of-life Python version is shipped as an ordinary change, as in deadline-cloud-worker-agent.
Does this change impact security?
It resolves a RUSTSEC advisory; no threat model needed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.