Repository navigation
ci: allow automated reviews for dependency requirements - #381
Draft
karthikbekalp wants to merge 5 commits into
Draft
karthikbekalp wants to merge 5 commits into
karthikbekalp wants to merge 5 commits into
Conversation
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
karthikbekalp
enabled auto-merge (squash)
November 16, 2026 19:44
karthikbekalp
marked this pull request as draft
November 16, 2026 21:16
auto-merge was automatically disabled
November 16, 2026 21:16
Pull request was converted to draft
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
karthikbekalp
marked this pull request as ready for review
November 16, 2026 21:27
karthikbekalp
enabled auto-merge (squash)
November 16, 2026 21:27
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
karthikbekalp
marked this pull request as draft
November 16, 2026 21:57
auto-merge was automatically disabled
November 16, 2026 21:57
Pull request was converted to draft
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
karthikbekalp
marked this pull request as ready for review
November 16, 2026 22:48
karthikbekalp
enabled auto-merge (squash)
November 16, 2026 22:53
karthikbekalp
marked this pull request as draft
November 17, 2026 16:53
auto-merge was automatically disabled
November 17, 2026 16:53
Pull request was converted to draft
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #363, #375, #339, #350
What was the problem/requirement? (What/Why)
Dependabot updates dependencies in the root
requirements-release.txt,requirements-testing.txt, andrequirements-development.txtfiles. Unattended dependency updates need these files to be exempt from code-owner review while other files retain a valid developer-team owner.GitHub's CODEOWNERS parser also reports the current
@OpenJobDescription/Developersowner as unknown. That team does not have write access to this repository.What was the solution? (How)
Use the existing
@OpenJobDescription/sync-team-openjd-developersteam, which has maintain access to the repository, for the catch-all ownership rule. Add ownerless, root-anchored entries for the three requirement files after it. This is a one-repository pilot for unattended dependency updates.What is the impact of this change?
Eligible dependency PRs that change only these root requirement files can satisfy the existing two-approval requirement through automated reviewers. Human PRs changing only these files also no longer require a code-owner review. Required checks and the approval count continue to apply.
This removes the code-owner blocker. The dependency auto-merge app's other eligibility checks continue to apply, so the exception alone does not make every Dependabot PR eligible for unattended merging.
All other files, including
pyproject.toml,hatch.toml, CODEOWNERS itself, and workflows, are assigned to the developer team with repository write access. A PR changing both an exempt file and an owned file still requires a code-owner review.How was this change tested?
git diff --checkpassed.hatch run lintpassed.hatch run test -n 4: 1,014 passed, 40 skipped, 16 xfailed; one macOS process-group test failed because the local execution environment denies/bin/ps. Full GitHub CI must pass before merging.semantic-release version --print --patchpassed withpython-semantic-release10.6.2 and each of GitPython 3.1.59 and 3.2.1, printing the same next version. This checks release initialization and version calculation; it does not publish a release.The dependency auto-merge app approved and merged GitPython update #363 on 2026-11-16 alongside the existing GitHub Actions approval. Dependabot then closed #375 because GitPython was already updated. This confirms the two-bot approval and merge path under the current configuration; the proposed CODEOWNERS configuration has not merged yet.
After this change merges, verify that GitHub reports no CODEOWNERS errors on the default branch and that developer-team review remains required for owned files. Verify unattended merging on a future eligible PR changing only the listed requirement files before extending these exceptions to other repositories.
Was this change documented?
The purpose of the exemptions is documented inline in CODEOWNERS.
Is this a breaking change?
No public runtime interface changes.
Does this change impact security?
Yes: the three requirement files are exempted from mandatory code-owner review for every author. The exact, root-anchored patterns limit the exemptions to those files, and the existing approval and CI requirements remain enforced. Changes to
pyproject.toml,hatch.toml, and workflows continue to require code-owner review.Cross-port to openjd-rs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.