Repository navigation
reject unrecognized Transfer-Encoding in httpGetLength - #208
Open
tanjiroK-coder wants to merge 1 commit into
Open
tanjiroK-coder wants to merge 1 commit into
tanjiroK-coder wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transfer-Encoding not recognized as chunked falls back to Content-Length
_httpUpdatekeeps trailing whitespace on header values andhttpGetLengthonly matches a Transfer-Encoding of exactlychunked, soTransfer-Encoding: chunked(trailing space) or two Transfer-Encoding headers (joined tochunked, chunked) are framed by Content-Length instead. A front end that follows RFC 9112 sees a chunked body, while a libcups server (ippeveprinter, PAPPL) reads Content-Length bytes and parses the rest of the chunk as the next request on the connection (TE.CL request smuggling).Repro against master:
POSTwithTransfer-Encoding: chunked,Content-Length: 4and a chunk containingGET /smuggled HTTP/1.1. The body comes back as the 4 bytes23\r\nand the nexthttpReadRequestreturnsGET /smuggled. With this change trailing OWS is trimmed (RFC 9110 section 5.5) and any other Transfer-Encoding is treated as a bad length rather than ignored (RFC 9112 section 6.1). The new testhttp cases fail 3 of 4 on master and pass here; the tools tests still pass.