Skip to content

Remove results dict #94

Open

Description

@1-Bart-1
  • Make solve! less allocating
  • Add all the Dict fields to the results struct
  • Rewrite plotting functions to use the results struct
  • Remove the solve() function

Activity

  1. added this to the Version 1.2 milestone on Mar 5, 2025
  2. ufechner7 commented on Mar 22, 2025

    @ufechner7
    Member

    I would suggest:

    1. remove the first point and put it into a separate issue

    To be discussed: Do we want to have one VSMSolution struct, or two, a small and a large one.

  3. 1-Bart-1 commented on Mar 22, 2025

    @1-Bart-1
    MemberAuthor

    One big struct for now, we can add a smaller one in a new issue. I marked the first point as done, as you did some great progress there already.

  4. 1-Bart-1 commented on Mar 22, 2025

    @1-Bart-1
    MemberAuthor

    And for the struct field names: we should stay close to the current dict names. But things like "Fx", "Fy", "Fz" can be combined in one "F" or "force" field.

  5. ufechner7 commented on Mar 22, 2025

    @ufechner7
    Member

    @1-Bart-1 Can you please create a pull request, just defining the new version of the VSMSolution struct that you suggest? I would then comment there. I think it would be good to have Union{MVec, Nothing} for new fields like a force. Then we could skip calculating these values when we don't need them, for example using a parameter like shortsolution=true for the solve function.

  6. ufechner7 commented on Mar 22, 2025

    @ufechner7
    Member

    "F" or "force" field

    I prefer lower case names for variables and attributes. CamelCase case should be reserved for types and structs.

  7. 1-Bort-1 commented on Sep 22, 2026

    @1-Bort-1
    Member

    Queued as VortexStepMethod.jl-94.

  8. 54 remaining items

  9. 1-Bort-1 commented on Nov 19, 2026

    @1-Bort-1
    Member

    Paused: claude is marked out of quota until somebody clears that. This carries on by itself, and nobody has to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions