You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And for the struct field names: we should stay close to the current dict names. But things like "Fx", "Fy", "Fz" can be combined in one "F" or "force" field.
@1-Bart-1 Can you please create a pull request, just defining the new version of the VSMSolution struct that you suggest? I would then comment there. I think it would be good to have Union{MVec, Nothing} for new fields like a force. Then we could skip calculating these values when we don't need them, for example using a parameter like shortsolution=true for the solve function.
Activity
ufechner7 commentedon Mar 22, 2025
I would suggest:
To be discussed: Do we want to have one VSMSolution struct, or two, a small and a large one.
1-Bart-1 commentedon Mar 22, 2025
One big struct for now, we can add a smaller one in a new issue. I marked the first point as done, as you did some great progress there already.
1-Bart-1 commentedon Mar 22, 2025
And for the struct field names: we should stay close to the current dict names. But things like "Fx", "Fy", "Fz" can be combined in one "F" or "force" field.
ufechner7 commentedon Mar 22, 2025
@1-Bart-1 Can you please create a pull request, just defining the new version of the VSMSolution struct that you suggest? I would then comment there. I think it would be good to have
Union{MVec, Nothing}for new fields like a force. Then we could skip calculating these values when we don't need them, for example using a parameter likeshortsolution=truefor the solve function.ufechner7 commentedon Mar 22, 2025
I prefer lower case names for variables and attributes. CamelCase case should be reserved for types and structs.
1-Bort-1 commentedon Sep 22, 2026
Queued as
VortexStepMethod.jl-94.54 remaining items
1-Bort-1 commentedon Nov 19, 2026
Paused: claude is marked out of quota until somebody clears that. This carries on by itself, and nobody has to do anything.