Auto-assign event priority to a single unprioritized event by dweindl · Pull Request #562 · PEtab-dev/libpetab-python

dweindl · 2026-10-19T18:06:13Z

ExperimentsToSbmlConverter now assigns a priority to a pre-existing model event without priority if it is the only such event and default_priority is not provided. The assigned priority is lower than all other finite priorities in the model (or 0 if there are none), and the condition-change events get max + 1 as before. This way, the condition-change events are executed before this event, e.g., in PEtab test suite case 0030, where previously the order was undefined.

Per SBML L3V2 §4.12.3/§8.2.5, the order of events without priority is undefined, so assigning a priority only selects one admissible order. Since the assigned value is distinct from all other priorities, no ties are introduced, which would require random execution order. With multiple unprioritized events, nothing is assigned automatically, as this would impose an arbitrary order on them if they are executed simultaneously.

This implements step 1 of #526, generalized to the case of one unprioritized event among prioritized ones (the partial-priority example in the issue). For the automatic assignment, a <priority> without math is treated as unset. If any other event has priority -inf or NaN, nothing is assigned, as no distinct lower priority exists. If any pre-existing event has priority +inf or NaN, a warning is emitted, since the condition-change events cannot be assigned a higher priority. The warning for unprioritized events is left for #525.

References #526

🤖 Generated with Claude Code

codecov-commenter · 2026-10-19T18:12:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.44%. Comparing base (57f3a49) to head (12f0553).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   78.20%   78.44%   +0.23%     
==========================================
  Files          68       68              
  Lines        7845     7876      +31     
  Branches     1400     1406       +6     
==========================================
+ Hits         6135     6178      +43     
+ Misses       1224     1214      -10     
+ Partials      486      484       -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dilpath · 2026-10-20T12:54:38Z

@@ -31,10 +35,14 @@ class ExperimentsToSbmlConverter:
    experiments to initial assignments and events as far as possible.

    If the model already contains events, PEtab events are added with a higher


Suggested change

If the model already contains events, PEtab events are added with a higher

If the model already contains events, SBML events are added with a higher

dilpath · 2026-10-20T13:03:27Z

    If the model already contains events, PEtab events are added with a higher
-    priority than the existing events to guarantee that PEtab condition changes
-    are applied before any pre-existing assignments.
+    priority than the existing events, so that PEtab condition changes are


Suggested change

priority than the existing events, so that PEtab condition changes are

priority than the pre-existing events, so that PEtab condition changes are

dilpath · 2026-10-20T13:05:25Z

+E0_PRIO = "E0: at time >= 10, priority=-2, fromTrigger=false: C = C * 2"
+E1 = "E1: at time >= 20, fromTrigger=false: C = C"
+E1_PRIO = "E1: at time >= 20, priority=5, fromTrigger=false: C = C"
+E1_PRIO_INF = "E1: at time >= 20, priority=-inf, fromTrigger=false: C = C"


Also test the priority=inf case, where it becomes impossible to create the new SBML event?

Added warning and test

dilpath · 2026-10-20T13:07:56Z

+    assert _event_priorities(problem.model.sbml_model) == {"E0": None}
+
+
+def test_explicit_default_priority():


Also test that default priority only affects events with undefined priority?

Extended the test. Includes an event with defined priority which is confirmed to be preserved.

dilpath · 2026-10-20T13:10:33Z

+            if not math.isfinite(priority):
+                # no distinct lower priority available
+                return


If only a lower priority is required here, then I guess +inf is fine here?

It's allowed now

dilpath · 2026-10-20T13:14:06Z

+            if priority.free_symbols:
+                # raises NotImplementedError in _preprocess
+                return


Raise here too, or will it be fixed here automatically when it's fixed in _preprocess?

Now handled in _get_event_priorities

`ExperimentsToSbmlConverter` now assigns a priority to a pre-existing model event without priority if it is the only such event, so that the condition-change events are executed before it. The assigned priority is lower than all other finite priorities in the model, so no ties are introduced. This only applies if `default_priority` is not provided, and not if any other event has priority `-inf` or `NaN`. Previously, the order of such events relative to the condition-change events was undefined (e.g., PEtab test suite case 0030). Additionally, warn if a pre-existing event has priority `+inf` or `NaN`, since the condition-change events cannot be assigned a higher priority. References PEtab-dev#526 Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

dweindl mentioned this pull request Oct 19, 2026

ExperimentsToSbmlConverter: assign a safe default event priority automatically where possible #526

Open

dweindl force-pushed the auto_event_priority branch from e5b1b36 to 6946c4d Compare October 19, 2026 18:08

dweindl marked this pull request as ready for review October 19, 2026 18:38

dweindl requested a review from a team as a code owner October 19, 2026 18:38

dweindl self-assigned this Oct 19, 2026

dweindl force-pushed the auto_event_priority branch from 6946c4d to c0ba478 Compare October 20, 2026 05:47

dilpath approved these changes Oct 20, 2026

View reviewed changes

dweindl force-pushed the auto_event_priority branch from c0ba478 to 4002964 Compare October 20, 2026 19:42

Merge branch 'main' into auto_event_priority

12f0553

dweindl enabled auto-merge (squash) October 20, 2026 20:15

dweindl merged commit e654711 into PEtab-dev:main Oct 20, 2026
7 checks passed

dweindl deleted the auto_event_priority branch October 20, 2026 20:20

Navigation Menu

Repository navigation

Auto-assign event priority to a single unprioritized event - #562

Auto-assign event priority to a single unprioritized event#562
dweindl merged 2 commits into
PEtab-dev:mainfrom
dweindl:auto_event_priority

dweindl commented Oct 19, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Oct 19, 2026 •

edited

Loading

Uh oh!

dilpath Oct 20, 2026

Uh oh!

dweindl Oct 20, 2026

Uh oh!

dilpath Oct 20, 2026

Uh oh!

dilpath Oct 20, 2026

Uh oh!

dweindl Oct 20, 2026

Uh oh!

dilpath Oct 20, 2026

Uh oh!

dweindl Oct 20, 2026

Uh oh!

dilpath Oct 20, 2026

Uh oh!

dweindl Oct 20, 2026

Uh oh!

dilpath Oct 20, 2026

Uh oh!

dweindl Oct 20, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -31,10 +35,14 @@ class ExperimentsToSbmlConverter:
		experiments to initial assignments and events as far as possible.

		If the model already contains events, PEtab events are added with a higher

	If the model already contains events, PEtab events are added with a higher
	If the model already contains events, SBML events are added with a higher

	priority than the existing events, so that PEtab condition changes are
	priority than the pre-existing events, so that PEtab condition changes are

		assert _event_priorities(problem.model.sbml_model) == {"E0": None}


		def test_explicit_default_priority():

Conversation

dweindl commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dweindl commented Oct 19, 2026 •

edited

Loading

codecov-commenter commented Oct 19, 2026 •

edited

Loading