Repository navigation
Update examples to Nutrient Web SDK 1.25.0 and fix the update workflow - #113
Merged
Merged
Conversation
pnpm audit --fix=override pins the first patched version an advisory names, even when that version was never published. For the 1.25.0 bump it wrote deepmerge@^4.3.2 into examples/svelte-kit, but deepmerge stops at 4.3.1, so the install after it failed and the update workflow stopped before opening its pull request. The audit fix now drops each override it just added that no published version satisfies and says so, and keeps an override when the registry lookup fails for any other reason.
ubuntu-latest now resolves to Ubuntu 26.04, where Playwright 1.56 cannot install Chromium, so the workflow failed before its e2e step. playwright.yml has been pinned to ubuntu-24.04 since the 1.24.0 bump; this pins the update workflow the same way.
vladimir-tikhonov-nutrient
changed the base branch from
vtikhonov/update-nutrient-sdk-1.25.0
to
main
November 2, 2026 15:40
vladimir-tikhonov-nutrient
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps every example to Nutrient Web SDK 1.25.0. It also fixes the two problems that stopped the update workflow from opening this PR itself.
pnpm audit --fix=overridewrotedeepmerge@^4.3.2intoexamples/svelte-kit, but that version doesn't exist: the deepmerge advisory GHSA-gcqx-w48m-w2h4 has no patched release. The install after it failed and the bump stopped.run_pnpm_audit_fixnow drops any override it just added that no published version matches, and logs it. If the registry lookup fails for any other reason, it keeps the override.ubuntu-latestis Ubuntu 26.04 now, where Playwright 1.56 can't install Chromium. The update workflow now runs onubuntu-24.04, likeplaywright.yml.Commits:
scripts/pnpm-helpers.sh.github/workflows/update-nutrient-sdk.yml@nutrient-sdk/viewerand CDN references move from 1.24.0 to 1.25.0, plus the audit fixes.The update workflow ran from this branch for 1.25.0 and passed, e2e smoke tests included: https://github.com/PSPDFKit/nutrient-web-examples/actions/runs/41471879240. Its log shows the fix at work: "No published deepmerge matches ^4.3.2; dropping the audit override for deepmerge@>=4.2.0 <=4.3.1." The workflow opened this PR, so the Biome and Playwright workflows didn't run on it. The run covers both.
Please check before merging
svelte-kit and vue-composition-api aren't in the e2e suite, and both picked up new audit overrides:
@sveltejs/kit3. Two low-severity SvelteKit advisories are fixed only in 3.0.0. The example still uses@sveltejs/adapter-auto7, which declares@sveltejs/kit ^2, and TypeScript 5.9, while kit 3 expects TypeScript 6. Please run the example. If it breaks, either move it to adapter-auto 8 and TypeScript 6, or drop that override.glob@7.2.3, whichmainalready forces onto minimatch 10, so this is a smaller step.Type
Checklist
pnpm run formatpasses (Biome), in the workflow run abovestartandstart:e2escripts inpackage.json(no new example)README.mdincluded with prerequisites, setup, and usage (no new example)@nutrient-sdk/viewerversion