Repository navigation
Support Infernalist's Pyromantic Pact - #2580
Open
lord-fluffy wants to merge 1 commit into
Open
lord-fluffy wants to merge 1 commit into
lord-fluffy wants to merge 1 commit into
Conversation
"Maximum Mana is replaced by twice as much Maximum Infernal Flame" and "Gain Infernal Flame instead of spending Mana for Skill costs" didn't parse, so Infernalists with the node were calculated with their full Mana pool and paying Mana costs. Maximum Mana now becomes 0 and Maximum Infernal Flame twice the Mana it replaced; Mana costs (per use and per second) are shown as Infernal Flame gained instead, with the same breakdown. Both show in the Calcs tab and the sidebar. The node's other lines (Infernal Flame loss, taking damage at maximum) are events PoB doesn't simulate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Maximum Mana is replaced by twice as much Maximum Infernal Flame" and "Gain Infernal Flame instead of spending Mana for Skill costs" didn't parse, so Infernalists with the node were calculated with their full Mana pool and paying Mana costs.
Maximum Mana now becomes 0 and Maximum Infernal Flame twice the Mana it replaced; Mana costs (per use and per second) are shown as Infernal Flame gained instead, with the same breakdown. Both show in the Calcs tab and the sidebar. The node's other lines (Infernal Flame loss, taking damage at maximum) are events PoB doesn't simulate.
Description of the problem being solved:
Pyromantic Pact's "Maximum Mana is replaced by twice as much Maximum Infernal Flame" and "Gain Infernal Flame instead of spending Mana for Skill costs" didn't parse, so Infernalists with the node were calculated with their full Mana pool and paying Mana costs (including "not enough Mana" warnings).
With the node, maximum Mana is 0 and Maximum Infernal Flame is twice the Mana it replaced. Mana costs (per use and per second) are shown as Infernal Flame gained instead, with the same breakdown. They appear in the Calcs tab (Mana section, skill costs) and the sidebar. ModCache.lua is regenerated; only the Pact lines change. The node's other lines (Infernal Flame loss, taking damage at maximum) are events PoB doesn't simulate, so they stay unsupported.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: