Repository navigation
fix: build on Android (Bionic errno accessor, inotify_rm_watch descriptor type) - #114
Conversation
…ptor type) set_errno used glibc's __errno_location on Android too; Bionic only has __errno. Android's libc declares inotify_rm_watch's descriptor as u32 (glibc/musl c_int); the descriptor is checked non-negative before the call, so the conversion is lossless. Checked: cargo check -p turnloop for aarch64-linux-android, aarch64/x86_64 linux-gnu, aarch64-apple-darwin.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
perry's release build for aarch64/x86_64-linux-android fails in turnloop 0.1.0-alpha.8:
libc::__errno_locationdoes not exist on Bionic (fs/unix.rs set_errno; backend/ipc.rs already uses__errnothere), andinotify_rm_watchtakes au32descriptor on Android. Both fixed;cargo check -p turnlooppasses for aarch64-linux-android, aarch64/x86_64-unknown-linux-gnu and aarch64-apple-darwin.Summary by CodeRabbit