Repository navigation
[Vanilla fix] Fix terrain types freeing cached SHP image references - #2459
Open
Krisztiaan wants to merge 1 commit into
Open
Krisztiaan wants to merge 1 commit into
Krisztiaan wants to merge 1 commit into
Conversation
Krisztiaan
changed the title
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Coronia
added
❓Vanilla bug
NetsuNegi
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Description
TerrainTypedestructors can deleteSHPreferences still retained by theFileSystemcache. Subsequent mission restarts can reuse the freed memory and corrupt unrelated data. This was reproduced in Global Crisis’sTUTO4after two in-game restarts.Clear borrowed
SHPreferences before native deletion in both terrain destructor paths. Owned images and raw theater images retain their existing cleanup behavior.An equivalent standalone correction passed two in-game restarts under Wine with the full campaign DLL set.