Skip to content

Remove the staging v2 route checks that need the Public API's catalog first - #1088

Merged
anth-volk merged 1 commit into
mainfrom
ci/remove-staging-v2-route-checks
Nov 17, 2026
Merged

anth-volk merged 1 commit into
mainfrom
ci/remove-staging-v2-route-checks

Conversation

@anth-volk

Copy link
Copy Markdown
Contributor

Fixes #1087

Same-Repository Draft PR Check

  • This PR is a draft.
  • This PR is from a branch in PolicyEngine/policyengine-sim-api, not a personal fork.

Changelog

  • This PR adds a changelog fragment, changelog.d/remove-staging-v2-route-checks.removed.md, whose type is breaking, added, changed, fixed or removed.

Summary

  • Removes the two staging checks that run through the v2 routes after the deploy moves the v2 default: staging_household_check (from Calculate stored households as household jobs through /household-calculations #1046) and staging_economy_check (from Create economy reports and simulations through POST /reports and POST /simulations #1052). deployment_ready no longer needs them or checks their results.
  • Why: both routes look up the Public API's catalog version for the default worker's policyengine.py version, and the Public API publishes catalog rows only for the version it has installed. The Public API cannot move to a new version until this service has deployed it, so every new version failed these checks on staging and skipped the production deploy. Deploy run 43946222393 (policyengine.py 6.20.0, chore(deps): update policyengine to 6.20.0 #1076) failed this way, with 400 unknown_catalog_version from both routes.
  • Effect: after a deploy of a new version, the v2 routes (POST /reports, POST /household-calculations) answer unknown_catalog_version until the Public API's own deploy publishes that version's catalog. Nothing else changes: the main simulation path, routing and every other check are as before.
  • Deletes test_staging_household_check.py and test_staging_economy_check.py, whose workflow tests assert the removed jobs, and changes test_deployment_assets.py's count of jobs that declare the release environment from 19 to 17.
  • Left as they are: the four scripts the jobs ran (.github/scripts/simulation-staging-{household,economy}-{check,ready}.sh), which no workflow now calls, and the two sections of projects/policyengine-simulation-entry/DEPLOYMENT.md that describe the checks.

Environment variables

The removed jobs read vars.SIMULATION_STAGING_HOUSEHOLD_ID (a beta environment variable, now read by nothing) and the secrets SIMULATION_ENTRYPOINT_AUTH_ISSUER, SIMULATION_ENTRYPOINT_AUTH_AUDIENCE, SIMULATION_ENTRYPOINT_TEST_AUTH_CLIENT_ID and SIMULATION_ENTRYPOINT_TEST_AUTH_CLIENT_SECRET, which the remaining jobs still read as before. The change adds no variable.

Testing

  • projects/policyengine-simulation-entry/tests/test_deployment_assets.py::test_deployment_uses_gcloud_workflow_without_terraform passes with the count of 17.
  • actionlint on .github/workflows/simulation-deploy.reusable.yml reports nothing, and no remaining needs names a removed job.
  • scripts/run_quality_guards.py: every guard passes, including rules-registry and ci-scripts. No rule in rules/registry.toml names the removed checks.

🤖 Generated with Claude Code

… first

The staging household and economy checks run after the deploy moves the
v2 default to the release's worker, and both routes look up the Public
API's catalog version for that worker's policyengine.py version. The
Public API publishes catalog rows only for the version it has
installed, and it cannot move to a new version until this service has
deployed it, so every new version failed the staging deploy and skipped
production (deploy run 43946222393, for 6.20.0).

Remove both jobs and their requirements from deployment_ready, delete
their workflow tests, and count 17 jobs that declare the release
environment instead of 19.

Fixes #1087

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@anth-volk
anth-volk marked this pull request as ready for review November 17, 2026 07:01
@anth-volk
anth-volk merged commit 771af4d into main Nov 17, 2026
27 checks passed
@anth-volk
anth-volk deleted the ci/remove-staging-v2-route-checks branch November 17, 2026 07:02
anth-volk added a commit that referenced this pull request Nov 17, 2026
Brings in policyengine.py 6.20.0 (#1076) and #1088, which removes the
staging household and economy check jobs from the deploy workflow,
because a new .py version has no Public API catalog rows until the
Public API deploys it.

Two conflicts, resolved to main's side:
- `simulation-deploy.reusable.yml`: both check jobs are removed, which
  also drops this branch's renamed economy check step and its comment.
  This branch's removal of `V2_SIMULATION_OUTPUT_BUCKET_VALUE` from the
  entrypoint's deploy step stays.
- `tests/test_staging_economy_check.py`: deleted with its job, as main
  deletes it. The script `.github/scripts/simulation-staging-economy-check.sh`
  keeps this branch's forced re-run; main keeps the script too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk added a commit that referenced this pull request Nov 17, 2026
`main` removed the staging v2 route checks from the deploy workflow and the
entry's tests (#1088), none of which this branch changes; no conflict.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk added a commit that referenced this pull request Nov 17, 2026
#1088 removed the staging_economy_check job and its tests; this takes
main's workflow and keeps the test file deleted. The check's script,
which #1088 left with no caller, keeps this branch's data_source body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the staging v2 route checks that need the Public API's catalog first

1 participant