Repository navigation
Remove the staging v2 route checks that need the Public API's catalog first - #1088
Merged
Merged
Conversation
… first The staging household and economy checks run after the deploy moves the v2 default to the release's worker, and both routes look up the Public API's catalog version for that worker's policyengine.py version. The Public API publishes catalog rows only for the version it has installed, and it cannot move to a new version until this service has deployed it, so every new version failed the staging deploy and skipped production (deploy run 43946222393, for 6.20.0). Remove both jobs and their requirements from deployment_ready, delete their workflow tests, and count 17 jobs that declare the release environment instead of 19. Fixes #1087 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
marked this pull request as ready for review
November 17, 2026 07:01
anth-volk
added a commit
that referenced
this pull request
Nov 17, 2026
Brings in policyengine.py 6.20.0 (#1076) and #1088, which removes the staging household and economy check jobs from the deploy workflow, because a new .py version has no Public API catalog rows until the Public API deploys it. Two conflicts, resolved to main's side: - `simulation-deploy.reusable.yml`: both check jobs are removed, which also drops this branch's renamed economy check step and its comment. This branch's removal of `V2_SIMULATION_OUTPUT_BUCKET_VALUE` from the entrypoint's deploy step stays. - `tests/test_staging_economy_check.py`: deleted with its job, as main deletes it. The script `.github/scripts/simulation-staging-economy-check.sh` keeps this branch's forced re-run; main keeps the script too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 17, 2026
anth-volk
added a commit
that referenced
this pull request
Nov 17, 2026
`main` removed the staging v2 route checks from the deploy workflow and the entry's tests (#1088), none of which this branch changes; no conflict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1087
Same-Repository Draft PR Check
PolicyEngine/policyengine-sim-api, not a personal fork.Changelog
changelog.d/remove-staging-v2-route-checks.removed.md, whose type is breaking, added, changed, fixed or removed.Summary
staging_household_check(from Calculate stored households as household jobs through /household-calculations #1046) andstaging_economy_check(from Create economy reports and simulations through POST /reports and POST /simulations #1052).deployment_readyno longer needs them or checks their results.400 unknown_catalog_versionfrom both routes.POST /reports,POST /household-calculations) answerunknown_catalog_versionuntil the Public API's own deploy publishes that version's catalog. Nothing else changes: the main simulation path, routing and every other check are as before.test_staging_household_check.pyandtest_staging_economy_check.py, whose workflow tests assert the removed jobs, and changestest_deployment_assets.py's count of jobs that declare the release environment from 19 to 17..github/scripts/simulation-staging-{household,economy}-{check,ready}.sh), which no workflow now calls, and the two sections ofprojects/policyengine-simulation-entry/DEPLOYMENT.mdthat describe the checks.Environment variables
The removed jobs read
vars.SIMULATION_STAGING_HOUSEHOLD_ID(abetaenvironment variable, now read by nothing) and the secretsSIMULATION_ENTRYPOINT_AUTH_ISSUER,SIMULATION_ENTRYPOINT_AUTH_AUDIENCE,SIMULATION_ENTRYPOINT_TEST_AUTH_CLIENT_IDandSIMULATION_ENTRYPOINT_TEST_AUTH_CLIENT_SECRET, which the remaining jobs still read as before. The change adds no variable.Testing
projects/policyengine-simulation-entry/tests/test_deployment_assets.py::test_deployment_uses_gcloud_workflow_without_terraformpasses with the count of 17.actionlinton.github/workflows/simulation-deploy.reusable.ymlreports nothing, and no remainingneedsnames a removed job.scripts/run_quality_guards.py: every guard passes, includingrules-registryandci-scripts. No rule inrules/registry.tomlnames the removed checks.🤖 Generated with Claude Code