Repository navigation
Certify the Microcosm UK pair built on policyengine-uk 2.177.7 - #759
Conversation
vahid-ahmadi
left a comment
There was a problem hiding this comment.
The code side looks right to me. The nested build-folder paths resolve correctly:
region_dataset_nameandresolve_region_dataset_pathmatch the newpath_templates exactly, so constituency and local-authority regions still route tomicrocosm_uk_2024_25_denseat4c594d72;dataset_logical_namestill givesmicrocosm_uk_2024_25;_bundle_destinationaccepts the nested paths.
The pins agree across pyproject.toml, manifest.json, uv.lock and both TROs. Two points:
- The local-area build isn't from Microcosm main.
- The body opens with "built from PolicyEngine/microcosm main". The dense build, though, is from
3dbf54e19, which GitHub compare puts 3 ahead of and 58 behind main. - That commit exists only on PolicyEngine/microcosm#1640, which is still open. Thanks for keeping it reachable with the merge in
65606b552. - Microcosm allows squash merges, though. If #1640 is squashed, the certified build's commit never reaches main, and the certificate points at a branch.
- Could #1640 land with a merge commit before this PR, as microcosm#1535 did before the last certification? Otherwise, could the body record the exception? Either way, the opening line should say the dense build comes from #1640.
- The body opens with "built from PolicyEngine/microcosm main". The dense build, though, is from
docs/households.md:159-162still says the production manifest pinspolicyengine-core3.33.3. It now pins 3.34.10.
Review drafted with AI assistance and checked against the code at e3173d4.
e3173d4 to
d88bd53
Compare
|
Thanks, Vahid. Point 2: fixed in I also rebased onto main after #750, which moved the US to policyengine-us 2.2.2. The lock, the bundle manifest and both TROs were regenerated on main rather than merged by hand. The manifest's UK release is identical to the one you reviewed, and its US release is main's. policyengine-us 2.2.2 accepts core 3.30.1 or later, so the core move still holds. The body's commit list and checks are updated. |
scripts/bundle.py certify-data on the national build uk-frs-calibration-attempt-20261115T104657Z-fcfac709 (hub commit ad84c060), with the local-area build uk-local-candidate-f100-s42-20261116T102715Z-e2745e59 (hub commit 4c594d72) as the regional release, at policyengine-uk 2.177.7, the version both were built with. It is the first UK certificate read from Microcosm's build folders: each file is pinned at releases/<release>/<build>/ and the commit that published it. The shared core pin moves from 3.33.3 to 3.34.10 (bundle.py update-packages), the core both builds were made on: policyengine-uk 2.177.4 and later need 3.34.9 or later, and policyengine-us 2.2.1 accepts it. uv.lock was re-resolved with uv 0.13.4; only policyengine-core and policyengine-uk move. Both TRO sidecars were regenerated. The certified test constants move to the pair in the build-folder form, with the local-area build's id and commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the UK model surface moves: its parameter count bucket goes from 48 to 50 hundreds. Every household value is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A build-folder certificate names the build (data_build_id), not a cut tag that starts with the release name, and its files keep their releases/<release>/<build>/ folder, in the default dataset URI and under the data directory a bundle install writes to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs/households.md listed the packages the production manifest pins for the US household SPM contract. The core pin is now 3.34.10, not 3.33.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d88bd53 to
f90d369
Compare
Main released 6.20.1 from #759's fragment before this PR merged, so the PR's patch fragment now cuts 6.20.2, the first release that ships the aliases. The 22 markers move from 6.20.1 to 6.20.2; nothing else changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This certifies the Microcosm UK pair built from PolicyEngine/microcosm main on 15–16 November, on policyengine-uk 2.177.7 and policyengine-core 3.34.10, so each build certifies on its own build. Both builds are published on
policyengine/populace-uk-privateand current in itsreleases.json.This is the first UK certificate read from Microcosm's build folders. Each file is pinned at
releases/<release>/<build>/and at the hub commit that published it, not at a tag.The national
uk-frs-calibration-attempt-20261115T104657Z-fcfac709(microcosm_uk_2024_25, releasemicrocosm-uk-2024-25-national):3a7067fa2, on Chronicle feed4ce631f5, with policyengine-uk 2.177.7 and policyengine-core 3.34.10.built_with_model_package).core_binding: bundle_pin), as on main.ad84c0602ed28f694ef52662eb9b063779e4e923and made current at 12:48 UTC. Its build staged locally only, so it was published with--allow-missing-staging.301d2fe5e7805c5a6242b37843cb118445aefd59a0593833362ab5a6e2f9ba90.The local area
uk-local-candidate-f100-s42-20261116T102715Z-e2745e59(microcosm_uk_2024_25_dense, releasemicrocosm-uk-2024-25-dense). Constituency and local-authority regions route to it (regional_release_kind: local_area).3dbf54e19, three commits on3a7067fa2, under review in UK dense: bus floor to 1.15%, four renewals and build 1r's gate-only sign-off (#1207, #1301) microcosm#1640:4c594d7243fdaec8913ef2543207f1d0934174aband made current at 12:49 UTC.436a680b336106b5bf68f766daa8798c903dee701441b2acc67cb57a6da308b8.Impact
cares_for_severely_disabled_person(2.177.3);==3.32.5claim, was already there at 3.33.3.eeb6093eand38605444to the builds above. UK results change with both.score_vs_enhanced_frs. It was an evidence file of the old national cut. The national build now shipsscore_vs_reference, since Microcosm scores a build against the current national build. Nothing loads it as a dataset, so no overlay keeps it.Commits
The branch is rebased on main at
6c2ef70c(6.20.0), after #750 moved the US to policyengine-us 2.2.2. The lock, the bundle manifest and both TROs were regenerated on main by the commands below, not merged by hand. The manifest's UK release is the one reviewed ate3173d4, apart from main's 6.20.0 bundle version, and its US release is main's.10125b77: the pair, certified by onecertify-datarun after the core pin move. It also carries:2c410ae0: the household calculator snapshots, regenerated on 2.177.7.536e1630: three bundle tests, moved from the tagged layout to the build-folder layout.f90d3696:docs/households.mdnames policyengine-core 3.34.10 as the production pin.The Test jobs already have 150 minutes (#744), so the workflows don't change.
How it was made
update-packages' own changelog fragment was dropped. The certification's fragment covers the core move.rewrite_certified_constants. The URIs then needed setting by hand, to the build-folder form (releases/<release>/<build>/<file>@<hub commit>), with the local-area build's id and commit beside them.Evidence
bundle.py check,check --include-tros --strict-trosandcheck --published-spm --include-tros --strict-trospass. Only the pre-existing US core warning above is raised.release_lock.pyanduv lock --checkpass.uv.lock, only policyengine-core (3.33.3 → 3.34.10) and policyengine-uk (2.174.1 → 2.177.7) move.eeb6093ethey were 0.913 and 0.939.🤖 Generated with Claude Code