Repository navigation
feat: check module activation in pollora:doctor and add pollora:module:frontend - #440
Merged
Merged
Conversation
…e:frontend Step 7 (framework part) of the modules specification: the module-activation check, the stock nwidart Vite config in the builds check, and pollora:module:frontend to move a module onto the template's frontend build.
# Conflicts: # CHANGELOG.md # src/Modules/Infrastructure/Providers/ModuleServiceProvider.php
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7 of the modules specification, framework part (docs and Nectar follow in their own repositories).
What changes
module-activationcheck (pollora:doctorand Site Health), warnings for:MODULES_ADMIN_TOGGLEon);MODULES_CONNECTOR/MODULES_LOCKED_*/MODULES_ENABLED|DISABLEDset whileconfig/modules.phpis not published — nwidart reads its activator before any provider, so they are ignored (the trap found in step 4).module:make(buildDirectory: 'build-<lower>') and points to the command below.pollora:module:frontend Crm: writespackage.json,vite.config.js(on@pollora/vite-config) andresources/assets/app.{js,css}from the bundled module template, keeping a.bakof each replaced file (--no-backup). No automatic migration at upgrade.Independent of #438/#439 (based on
develop).Tests
Pest:
ModuleDoctorTest(each warning, the passing case, the command with backup, unknown module) and the stock-config case inModuleChecksTest. Full suite 1941 passed; PHPStan, Rector, Pint, type coverage clean.