Repository navigation
Conversation
|
Test on Playground |
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
103 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
📁 classes/suggested-tasks/providers/class-content-review.php (4 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
232 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
377 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
381 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
388 |
WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in | Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information. |
📁 classes/activities/class-query.php (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
71 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58. |
163 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153. |
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
120 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118. |
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
111 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98. |
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
108 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
✅ Code Coverage Report
🎉 Great job maintaining/improving code coverage! 📊 File-level Coverage Changes (1 files)📉 Coverage Decreased
ℹ️ About this report
|
With the X-Progress-Planner-Token header every caller requests the same /get-stats and /tasks URL. WordPress sends no-cache headers only to logged-in users, and the server is not logged in, so a page cache could store an authenticated response and serve it to anyone, or hand the server stale data. LiteSpeed Cache caches REST responses for guests by default for seven days. Send Cache-Control: no-store, private on every response from these routes, including rejected ones and the legacy URLs, and call LiteSpeed Cache's litespeed_control_set_nocache hook because its own cache header overrides the standard one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the X-Progress-Planner-Token header every caller requests the same /get-stats and /tasks URL. WordPress sends no-cache headers only to logged-in users, and the server is not logged in, so a page cache could store an authenticated response and serve it to anyone, or hand the server stale data. LiteSpeed Cache caches REST responses for guests by default for seven days. Send Cache-Control: no-store, private on every response from these routes, including rejected ones, and call LiteSpeed Cache's litespeed_control_set_nocache hook because its own cache header overrides the standard one. Same change as on #805. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pushed c1131d8: keep Why. Before this PR the token was part of the URL (
What changed.
Each endpoint sets its route through a Cases covered
Verified
The server side adds a second layer in ProgressPlanner/progress-planner-server#69: a random query argument on every stats request, for caches that ignore headers. The same plugin change is on #803, so it isn't lost when the strict branches replace these REST changes. |
The server must be able to switch to
X-Progress-Planner-Tokenwhile installed plugins still accept its existing URL-based requests. This is the temporary compatibility stage, based directly ondevelop, to ship before the strict security branches./get-statsand/tasks.tokenparameter.token/prefix only in the URL fallback.Rollout: distribute this plugin first and verify each site is ready; deploy ProgressPlanner/progress-planner-server#68 plus ProgressPlanner/progress-planner-server#69 together; then ship plugin #802 plus #803 to remove URL authentication. The strict branches overlap these REST changes and must be reconciled before their later release. Existing keys are unchanged.
Validation: all 22 GitHub checks pass on
c83ea1ab, including the seven PHP/WordPress integration jobs, coverage, Plugin Check, both browser suites, and upgrade compatibility. PHPUnit passes with 501 tests / 1,460 assertions in single-site and multisite runs, including the 29 new authentication cases. Changed-file PHPCS and PHPStan also pass in an isolated, network-disabled local container. The branch is conflict-free againstdevelop. No release has been published or deployed.