Skip to content

Add JS/CSS lint and SBOM-on-release workflows - #809

Merged
jdevalk merged 2 commits into
developfrom
claude/ci-workflow-gaps-cc6ac8
Nov 18, 2026
Merged

jdevalk merged 2 commits into
developfrom
claude/ci-workflow-gaps-cc6ac8

Conversation

@jdevalk

@jdevalk jdevalk commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

Two CI gaps from the workflow audit:

  • lint-js-css.yml: runs the existing npm run lint:js and npm run lint:css on pushes to develop, on pull requests and on manual dispatch. Both scripts pass on the current code, so no fixes or baselines were needed.
  • sbom.yml: generates a CycloneDX SBOM with Syft when a release is published and attaches sbom-<tag>.json to the GitHub release. Modelled on the brand-assets workflow. deploy.yml is untouched and keeps handling the WordPress.org deploy and the plugin ZIP.
  • .eslintrc.js: adds root: true so ESLint does not pick up a parent directory's config (it failed in a nested git worktree). No effect in CI.

All actions are pinned to full commit SHAs and both workflows set minimal permissions:.

Testing

  • npm run lint:js and npm run lint:css exit 0 locally.
  • actionlint is clean on both files.
  • The SBOM workflow has not been run; its first real test is the next release. The same steps run successfully in brand-assets next to its deploy workflow.

Notes

  • lint:js skips assets/js/vendor; the TypeScript e2e tests are not linted.
  • The SBOM scans the source lock files, so it includes dev dependencies.
  • published also fires for prereleases, while deploy.yml only fires on released.
  • Re-running the SBOM job appends its note to the release body again.

🤖 Generated with Claude Code

jdevalk and others added 2 commits November 18, 2026 12:04
Run the existing lint:js and lint:css npm scripts on pushes to develop
and on pull requests. Both pass on the current code base.

Mark .eslintrc.js as the root config so ESLint does not pick up a
parent directory's config (for example when linting in a nested git
worktree).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Generate a CycloneDX SBOM with Syft when a release is published and
attach it to the GitHub release. Separate from deploy.yml, which keeps
handling the WordPress.org deploy and the plugin ZIP.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Test merged PR on Playground
Test this pull request on the Playground
or download the zip

@github-actions

Copy link
Copy Markdown
Contributor

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
10 0 10

⚠️ Warnings (10)

📁 classes/suggested-tasks/data-collector/class-unpublished-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
103 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/suggested-tasks/providers/class-content-review.php (4 warnings)
📍 Line 🔖 Check 💬 Message
232 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
377 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
381 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
388 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/activities/class-query.php (2 warnings)
📍 Line 🔖 Check 💬 Message
71 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58.
163 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153.
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
📍 Line 🔖 Check 💬 Message
108 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106.
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
111 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98.
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
📍 Line 🔖 Check 💬 Message
120 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@github-actions

Copy link
Copy Markdown
Contributor

✅ Code Coverage Report

Metric Value
Total Coverage 35.07% 📉
Base Coverage 35.07%
Difference 📈 0.00%

⚠️ Coverage below recommended 40% threshold

🎉 Great job maintaining/improving code coverage!

ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@jdevalk
jdevalk merged commit 231c030 into develop Nov 18, 2026
22 checks passed
@jdevalk
jdevalk deleted the claude/ci-workflow-gaps-cc6ac8 branch November 18, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant