Repository navigation
refactor: remove asap-planner's promql/sql/metricsql features (#1065) - #1087
Merged
milindsrivastava1997 merged 1 commit intoOct 30, 2026
Conversation
Every consumer needs all three frontends, so the frontend crates become regular dependencies. Removes the features, their cfgs, UserInputError::FrontendDisabled, the not(sql) test and the PromQL-only CI step. test-support stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
milindsrivastava1997
force-pushed
the
1065-refactor-remove-the-unused-promqlsqlmetricsql-frontend-features-of-asap-planner
branch
from
October 30, 2026 00:27
a167f8b to
8c13368
Compare
milindsrivastava1997
deleted the
1065-refactor-remove-the-unused-promqlsqlmetricsql-frontend-features-of-asap-planner
branch
October 30, 2026 01:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1065.
Why
asap-plannerput each frontend behind a cargo feature so that a PromQL-only runtime could avoid linking DataFusion and the MetricsQL parser. ASAPQuery-backend was that runtime, but it now has to support every language, so no consumer needs the PromQL-only build. Keeping the features costs 25cfgsites inlib.rs, feature-gated tests, a public error variant and a CI step.What and how
asap-frontend-{promql,sql,metricsql}become regular dependencies.promql/sql/metricsqlfeatures and everycfgthat used them;UserInputError::FrontendDisabledand the hiddenFrontendInput::NoSqlFeatureplaceholder;not(sql)test ine2e_plan.rs;UserInput::validatenow only checks that the frontend name matches the language. ElasticDSL still fails withFrontendMismatch.integration-testsasks only fortest-support, which stays.The backend gets the matching change in ProjectASAP/ASAPQuery-backend#850. That change works against the backend's current pinned rev, so the two PRs can merge in either order. The #1056 fix on
ci-speedwas reverted in #1071, so removing the CI step here does not conflict with it.Key code interfaces added / modified
promql,sqlandmetricsqlcargo features ofasap-planner.UserInputError::FrontendDisabled.Major algorithm changes: None.
Snapshot changes: None.
Before this PR
A SQL workload in that build fails with
UserInputError::FrontendDisabled { feature: "sql" }.After this PR
default-features = falseorfeatures = ["promql"]no longer resolves. Every language is always available, and planning results are unchanged.Testing
cargo clippy --workspace --all-targets -- -D warningsis clean.cargo test --workspacehas no failures.🤖 Generated with Claude Code