Skip to content

refactor: spell ASAP in ErrorBuildingLogicalASAPDagsFromChosenCandidates - #1092

Merged
zzylol merged 1 commit into
mainfrom
refactor/error-name-asap-casing
Oct 30, 2026
Merged

zzylol merged 1 commit into
mainfrom
refactor/error-name-asap-casing

Conversation

@zzylol

@zzylol zzylol commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #1052 (naming convention), for #1047.

Why

#1052 named the error type ErrorBuildingLogicalAsapDagsFromChosenCandidates, spelling ASAP as Asap. Every other type uses ASAP (LogicalASAPMemoCandidates, PhysicalASAPDAG), and the new Stage 2 error ErrorGeneratingPhysicalASAPMemoCandidates (#1047) does too.

What

Rename only: ErrorBuildingLogicalAsapDagsFromChosenCandidates → ErrorBuildingLogicalASAPDagsFromChosenCandidates. Nothing else changes.

How

A word-bounded replacement in the 3 files that name it:

  • crates/logical-asap-optimization/src/pass2/memo/enumeration.rs
  • crates/integration-tests/tests/memo_enumeration.rs
  • docs/design_docs/proposals/planner-layering.md

Key code interfaces added / modified

pass2/memo/enumeration.rs

pub enum ErrorBuildingLogicalASAPDagsFromChosenCandidates { /* variants unchanged */ } // was ErrorBuildingLogicalAsapDagsFromChosenCandidates

Usage: build_logical_asap_dags_from_chosen_candidates(memo, &chosen) returns Err(ErrorBuildingLogicalASAPDagsFromChosenCandidates::Cycle { .. }) on a cyclic choice, exactly as before.

Major algorithm changes

None.

Before / After

Before, the type was spelled …LogicalAsapDags…. After, it is spelled …LogicalASAPDags….

Verification

At 97c811f09:

  • fmt passes. clippy -p asap-logical-asap-optimization -p asap-integration-tests --all-targets -D warnings is clean.
  • asap-logical-asap-optimization --lib enumeration: 2 passed.
  • asap-integration-tests memo_enumeration: 3 passed.
  • No other occurrence remains (git grep LogicalAsapDags is empty).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zzylol
zzylol merged commit b1f001b into main Oct 30, 2026
@zzylol
zzylol deleted the refactor/error-name-asap-casing branch November 3, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant