Repository navigation
refactor: spell ASAP in ErrorBuildingLogicalASAPDagsFromChosenCandidates - #1092
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1052 (naming convention), for #1047.
Why
#1052 named the error type
ErrorBuildingLogicalAsapDagsFromChosenCandidates, spelling ASAP asAsap. Every other type usesASAP(LogicalASAPMemoCandidates,PhysicalASAPDAG), and the new Stage 2 errorErrorGeneratingPhysicalASAPMemoCandidates(#1047) does too.What
Rename only:
ErrorBuildingLogicalAsapDagsFromChosenCandidates→ErrorBuildingLogicalASAPDagsFromChosenCandidates. Nothing else changes.How
A word-bounded replacement in the 3 files that name it:
crates/logical-asap-optimization/src/pass2/memo/enumeration.rscrates/integration-tests/tests/memo_enumeration.rsdocs/design_docs/proposals/planner-layering.mdKey code interfaces added / modified
pass2/memo/enumeration.rsUsage:
build_logical_asap_dags_from_chosen_candidates(memo, &chosen)returnsErr(ErrorBuildingLogicalASAPDagsFromChosenCandidates::Cycle { .. })on a cyclic choice, exactly as before.Major algorithm changes
None.
Before / After
Before, the type was spelled
…LogicalAsapDags…. After, it is spelled…LogicalASAPDags….Verification
At
97c811f09:clippy -p asap-logical-asap-optimization -p asap-integration-tests --all-targets -D warningsis clean.asap-logical-asap-optimization --lib enumeration: 2 passed.asap-integration-tests memo_enumeration: 3 passed.git grep LogicalAsapDagsis empty).🤖 Generated with Claude Code